Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mac-filter] change whitelist/blacklist to allowlist/denylist #552

Merged
merged 3 commits into from
Sep 15, 2020

Conversation

jwhui
Copy link
Member

@jwhui jwhui commented Sep 9, 2020

To promote inclusivity and eliminate any unintentional bias.

Copy link
Member

@simonlingoogle simonlingoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@bukepo bukepo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:+1:

To promote inclusivity and eliminate any unintentional bias.
@codecov
Copy link

codecov bot commented Sep 11, 2020

Codecov Report

Merging #552 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #552   +/-   ##
=======================================
  Coverage   78.21%   78.21%           
=======================================
  Files          68       68           
  Lines        4683     4683           
=======================================
  Hits         3663     3663           
  Misses       1020     1020           
Impacted Files Coverage Δ
src/dbus/common/types.hpp 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 274c11a...e8584e4. Read the comment docs.

Copy link
Member

@bukepo bukepo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this PR update submodule of OpenThread ?

@bukepo
Copy link
Member

bukepo commented Sep 14, 2020

Can we merge this PR or merge #557 into this PR?

OPENTHREAD_CONFIG_FILE is now defined in OPENTHREAD_PROJECT_CFLAGS in
OpenThread. This PR adds the definition to fix android build check.
@jwhui
Copy link
Member Author

jwhui commented Sep 15, 2020

Can we merge this PR or merge #557 into this PR?

@bukepo, thanks for this! I just cherry-picked 19e32d1 into this PR.

@simonlingoogle simonlingoogle added P2 and removed P4 labels Sep 15, 2020
@simonlingoogle
Copy link
Member

Labeled as P2 since many other PRs are depending on this PR. @jwhui @bukepo

@jwhui jwhui merged commit 7a53c4c into openthread:master Sep 15, 2020
@jwhui jwhui deleted the macfilter branch September 15, 2020 04:05
simonlingoogle pushed a commit to simonlingoogle/ot-br-posix that referenced this pull request Nov 11, 2020
Bug: 167332999

* origin/github/master:
  [backbone-router] fix OT options for Backone Router (openthread#564)
  [script] add `REFERENCE_DEVICE` support (openthread#558)
  [test] increase the waiting time in dbus tests (openthread#563)
  [flags] configure backbone network interface name (openthread#553)
  [dockerfile] add ARG `OT_BACKBONE_CI` (openthread#556)
  [mac-filter] change whitelist/blacklist to allowlist/denylist (openthread#552)
  [third-party] only add web related modules when necessary (openthread#551)
  [web] topology visualization (openthread#519)
Change-Id: I73c08bf5bc0ebcc9ecb9903a282a2264e6754b0f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants