-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mac-filter] change whitelist/blacklist to allowlist/denylist #552
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM:+1:
To promote inclusivity and eliminate any unintentional bias.
Codecov Report
@@ Coverage Diff @@
## master #552 +/- ##
=======================================
Coverage 78.21% 78.21%
=======================================
Files 68 68
Lines 4683 4683
=======================================
Hits 3663 3663
Misses 1020 1020
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this PR update submodule of OpenThread ?
Can we merge this PR or merge #557 into this PR? |
OPENTHREAD_CONFIG_FILE is now defined in OPENTHREAD_PROJECT_CFLAGS in OpenThread. This PR adds the definition to fix android build check.
Bug: 167332999 * origin/github/master: [backbone-router] fix OT options for Backone Router (openthread#564) [script] add `REFERENCE_DEVICE` support (openthread#558) [test] increase the waiting time in dbus tests (openthread#563) [flags] configure backbone network interface name (openthread#553) [dockerfile] add ARG `OT_BACKBONE_CI` (openthread#556) [mac-filter] change whitelist/blacklist to allowlist/denylist (openthread#552) [third-party] only add web related modules when necessary (openthread#551) [web] topology visualization (openthread#519) Change-Id: I73c08bf5bc0ebcc9ecb9903a282a2264e6754b0f
To promote inclusivity and eliminate any unintentional bias.