[web] topology visualization #519

tttttangTH · 2020-07-10T13:54:28Z

It is the first PR of OpenThread Network Manager.

In general, it implements a new module -- OTBR-REST, which is directly embedded in OTBR-AGENT and provides RESTful API for a new feature of WEB UI -- Topology Visualization.

Topology Visualization aims to collect diagnostic information of all nodes in current network, visualize their relations and provide the display of all the details.

The frontend part is implemented based on the frontend of OTBR-WEB for the time being. We will then implement all the functionality OTBR-WEB provides and transplant the frontend static file of OTBR-WEB in this module. More details of the second PR is in #537 .

Update forks

lgtm-com · 2020-07-10T14:07:57Z

This pull request introduces 2 alerts when merging 210dc18 into eefef71 - view on LGTM.com

new alerts:

1 for Useless assignment to local variable
1 for 'new[]' array freed with 'delete'

codecov · 2020-07-10T19:19:52Z

Codecov Report

Merging #519 into master will increase coverage by 1.36%.
The diff coverage is 84.39%.

@@            Coverage Diff             @@
##           master     #519      +/-   ##
==========================================
+ Coverage   76.85%   78.21%   +1.36%     
==========================================
  Files          57       68      +11     
  Lines        3850     4683     +833     
==========================================
+ Hits         2959     3663     +704     
- Misses        891     1020     +129

Impacted Files	Coverage Δ
src/rest/request.cpp	`73.33% <73.33%> (ø)`
src/rest/connection.cpp	`73.88% <73.88%> (ø)`
src/rest/json.cpp	`77.86% <77.86%> (ø)`
src/rest/parser.cpp	`86.84% <86.84%> (ø)`
src/rest/rest_web_server.cpp	`88.04% <88.04%> (ø)`
src/rest/resource.cpp	`94.56% <94.56%> (ø)`
src/rest/response.cpp	`94.59% <94.59%> (ø)`
src/agent/main.cpp	`92.22% <100.00%> (+0.45%)`	⬆️
src/rest/connection.hpp	`100.00% <100.00%> (ø)`
src/rest/request.hpp	`100.00% <100.00%> (ø)`
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc8825d...474d15c. Read the comment docs.

simonlingoogle · 2020-07-11T16:34:56Z

Why not use git submodules for cJSON and http_parser ? @tttttangTH @wgtdkp

src/agent/rest_web_server.cpp

src/agent/rest_web_server.hpp

src/agent/rest_web_server.cpp

wgtdkp · 2020-07-12T02:07:56Z

Why not use git submodules for cJSON and http_parser ? @tttttangTH @wgtdkp

I think the benefits of adding source code is that we don't need to make a mirroring of each third_party library when porting to product environment where we cannot depends on external libraries directly. This is how OpenThread add third_party dependencies. OpenThread is added as a git submodule, because there is already an OpenThread mirroring in internal code base.

wgtdkp · 2020-07-12T02:43:16Z

@tttttangTH I think the first thing for you is to format the code with script/make-pretty clang.

lgtm-com · 2020-07-13T14:26:41Z

This pull request introduces 2 alerts when merging 83eaafd into eefef71 - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class
1 for 'new[]' array freed with 'delete'

lgtm-com · 2020-07-13T18:48:27Z

This pull request introduces 3 alerts when merging 0b136da into eefef71 - view on LGTM.com

new alerts:

1 for Resource not released in destructor
1 for Unused variable, import, function or class
1 for 'new[]' array freed with 'delete'

lgtm-com · 2020-07-14T03:07:27Z

This pull request introduces 1 alert when merging e38d30d into eefef71 - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

lgtm-com · 2020-07-14T04:09:37Z

This pull request introduces 1 alert when merging 77b0066 into eefef71 - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

lgtm-com · 2020-07-14T04:26:14Z

This pull request introduces 1 alert when merging 6329970 into eefef71 - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

src/web/web-service/frontend/res/js/app.js

src/agent/rest_web_server.hpp

src/web/web-service/frontend/res/js/app.js

lgtm-com · 2020-07-15T19:42:44Z

This pull request introduces 1 alert when merging a895bd4 into eefef71 - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

src/agent/CMakeLists.txt

src/agent/main.cpp

src/rest/CMakeLists.txt

src/rest/connection.cpp

src/rest/rest_web_server.cpp

src/rest/rest_web_server.hpp

wgtdkp · 2020-07-17T15:37:20Z

@tttttangTH You marked comments resolved, but there is no new commits. Can you confirm that you pushed you changes successfully?

src/agent/CMakeLists.txt

src/rest/connection.cpp

src/rest/connection.hpp

src/rest/request.hpp

src/rest/connection.cpp

simonlingoogle · 2020-07-17T16:23:17Z

src/rest/connection.cpp

+void Connection::SentResponse(Response &aResponse)
+{
+    std::string data = aResponse.SerializeResponse();
+    write(this->mFd, data.c_str(), data.size());


and we might not write all data, only part of it.

src/rest/rest_web_server.hpp

src/rest/rest_web_server.cpp

lgtm-com · 2020-08-16T14:48:02Z

This pull request fixes 2 alerts when merging 4fef6cc into ecc2570 - view on LGTM.com

fixed alerts:

2 for Useless assignment to local variable

lgtm-com · 2020-08-16T15:08:06Z

This pull request fixes 2 alerts when merging 59cf99b into ecc2570 - view on LGTM.com

fixed alerts:

2 for Useless assignment to local variable

tttttangTH · 2020-08-16T15:27:33Z

@tttttangTH please address comments by LGTM.com

Have fixed that!

third_party/http-parser/CMakeLists.txt

src/rest/CMakeLists.txt

src/rest/connection.cpp

src/rest/types.hpp

src/rest/rest_web_server.cpp

src/rest/rest_web_server.hpp

src/rest/rest_web_server.cpp

lgtm-com · 2020-08-17T17:07:41Z

This pull request fixes 2 alerts when merging fd37cd7 into ecc2570 - view on LGTM.com

fixed alerts:

2 for Useless assignment to local variable

lgtm-com · 2020-08-17T17:24:17Z

This pull request fixes 2 alerts when merging ea3e4d9 into ecc2570 - view on LGTM.com

fixed alerts:

2 for Useless assignment to local variable

lgtm-com · 2020-08-17T17:40:35Z

This pull request fixes 2 alerts when merging 4968af8 into ecc2570 - view on LGTM.com

fixed alerts:

2 for Useless assignment to local variable

[cmake] add option for enabling legacy in cmake (openthread#544)

src/web/web-service/frontend/res/js/app.js

lgtm-com · 2020-08-26T13:42:57Z

This pull request fixes 2 alerts when merging 6ca68f1 into bc8825d - view on LGTM.com

fixed alerts:

2 for Useless assignment to local variable

lgtm-com · 2020-08-26T15:51:58Z

This pull request fixes 2 alerts when merging 474d15c into bc8825d - view on LGTM.com

fixed alerts:

2 for Useless assignment to local variable

wgtdkp

LGTM 👍

Bug: 167332999 * origin/github/master: [backbone-router] fix OT options for Backone Router (openthread#564) [script] add `REFERENCE_DEVICE` support (openthread#558) [test] increase the waiting time in dbus tests (openthread#563) [flags] configure backbone network interface name (openthread#553) [dockerfile] add ARG `OT_BACKBONE_CI` (openthread#556) [mac-filter] change whitelist/blacklist to allowlist/denylist (openthread#552) [third-party] only add web related modules when necessary (openthread#551) [web] topology visualization (openthread#519) Change-Id: I73c08bf5bc0ebcc9ecb9903a282a2264e6754b0f

Merge pull request #1 from openthread/master

35a099f

Update forks

googlebot added the cla: yes label Jul 10, 2020

tttttangTH requested a review from simonlingoogle July 10, 2020 13:54

tttttangTH requested a review from wgtdkp July 10, 2020 14:18

wgtdkp changed the title ~~Topology visualization pre-review~~ [web] topology visualization Jul 11, 2020

simonlingoogle reviewed Jul 11, 2020

View reviewed changes

wgtdkp reviewed Jul 14, 2020

View reviewed changes

src/web/web-service/frontend/res/js/app.js Outdated Show resolved Hide resolved

bukepo reviewed Jul 15, 2020

View reviewed changes

src/agent/rest_web_server.hpp Outdated Show resolved Hide resolved

src/web/web-service/frontend/res/js/app.js Outdated Show resolved Hide resolved

wgtdkp reviewed Jul 16, 2020

View reviewed changes

simonlingoogle reviewed Jul 17, 2020

View reviewed changes

Tonghui Tang added 8 commits July 18, 2020 12:37

Add rest HTTP server

d69dcf9

Add 3rd party library cJSON into third-party directory

34f71c8

Add 3rd party library http-parser into third-party directory

9b1534d

Add 3rd party library d3js into third-party directory

82e4ce0

Add topology functionality

4377327

Add topology display in HTML file.

9d834f7

Add style for topology visualization

f6f50c2

Add library d3js to subdirectory

d44e55e

add node check

4fef6cc

fix test bug

59cf99b

wgtdkp reviewed Aug 17, 2020

View reviewed changes

Tonghui Tang added 2 commits August 18, 2020 00:51

modify CMakeList.txt file

d88c7f3

resolve comments

fd37cd7

fix package check fail

ea3e4d9

fix build fail

4968af8

Merge pull request #8 from openthread/master

78dcfcb

[cmake] add option for enabling legacy in cmake (openthread#544)

wgtdkp reviewed Aug 25, 2020

View reviewed changes

src/web/web-service/frontend/res/js/app.js Show resolved Hide resolved

wgtdkp reviewed Aug 26, 2020

View reviewed changes

src/web/web-service/frontend/res/js/app.js Outdated Show resolved Hide resolved

tttttangTH added 3 commits August 26, 2020 21:19

rename variable

a1a680f

Merge branch 'master' of github.com:openthread/ot-br-posix

c7bfdc1

Merge branch 'master' into manager-draft

6ca68f1

remove dead code

474d15c

bukepo approved these changes Sep 1, 2020

View reviewed changes

wgtdkp approved these changes Sep 1, 2020

View reviewed changes

wgtdkp requested a review from jwhui September 1, 2020 08:10

jwhui added comp: web service enhancement labels Sep 2, 2020

jwhui approved these changes Sep 2, 2020

View reviewed changes

jwhui merged commit ea9cd69 into openthread:master Sep 2, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[web] topology visualization #519

[web] topology visualization #519

tttttangTH commented Jul 10, 2020 •

edited

Loading

lgtm-com bot commented Jul 10, 2020

codecov bot commented Jul 10, 2020 •

edited

Loading

simonlingoogle commented Jul 11, 2020

wgtdkp commented Jul 12, 2020

wgtdkp commented Jul 12, 2020

lgtm-com bot commented Jul 13, 2020

lgtm-com bot commented Jul 13, 2020

lgtm-com bot commented Jul 14, 2020

lgtm-com bot commented Jul 14, 2020

lgtm-com bot commented Jul 14, 2020

lgtm-com bot commented Jul 15, 2020

wgtdkp commented Jul 17, 2020

simonlingoogle Jul 17, 2020

lgtm-com bot commented Aug 16, 2020

lgtm-com bot commented Aug 16, 2020

tttttangTH commented Aug 16, 2020

lgtm-com bot commented Aug 17, 2020

lgtm-com bot commented Aug 17, 2020

lgtm-com bot commented Aug 17, 2020

lgtm-com bot commented Aug 26, 2020

lgtm-com bot commented Aug 26, 2020

wgtdkp left a comment

[web] topology visualization #519

[web] topology visualization #519

Conversation

tttttangTH commented Jul 10, 2020 • edited Loading

lgtm-com bot commented Jul 10, 2020

codecov bot commented Jul 10, 2020 • edited Loading

Codecov Report

simonlingoogle commented Jul 11, 2020

wgtdkp commented Jul 12, 2020

wgtdkp commented Jul 12, 2020

lgtm-com bot commented Jul 13, 2020

lgtm-com bot commented Jul 13, 2020

lgtm-com bot commented Jul 14, 2020

lgtm-com bot commented Jul 14, 2020

lgtm-com bot commented Jul 14, 2020

lgtm-com bot commented Jul 15, 2020

wgtdkp commented Jul 17, 2020

simonlingoogle Jul 17, 2020

Choose a reason for hiding this comment

lgtm-com bot commented Aug 16, 2020

lgtm-com bot commented Aug 16, 2020

tttttangTH commented Aug 16, 2020

lgtm-com bot commented Aug 17, 2020

lgtm-com bot commented Aug 17, 2020

lgtm-com bot commented Aug 17, 2020

lgtm-com bot commented Aug 26, 2020

lgtm-com bot commented Aug 26, 2020

wgtdkp left a comment

Choose a reason for hiding this comment

tttttangTH commented Jul 10, 2020 •

edited

Loading

codecov bot commented Jul 10, 2020 •

edited

Loading