Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONTENT: After rework on NPCs, Buy in shopping bags was not implemented. #318

Closed
guispiller opened this issue Apr 17, 2022 · 1 comment · Fixed by #443
Closed

CONTENT: After rework on NPCs, Buy in shopping bags was not implemented. #318

guispiller opened this issue Apr 17, 2022 · 1 comment · Fixed by #443
Labels
Stale No activity Status: Pending Test This PR or Issue requires more testing Type: Missing Content Content that was not yet implemented or is not following the accepted standards

Comments

@guispiller
Copy link
Contributor

READ BEFORE PROCEEDING: OUR SERVER IS UPDATED DAILY. IF POSSIBLE MAKE SURE TO UPDATE TO THE LATEST VERSION BEFORE REPORTING.

Describe the wrong or missing content

It's missing the option to buy items in shopping bags (missing function on npclib)

Additional context

Before the rework on npcs, it was working fine.
@guispiller guispiller added the Type: Missing Content Content that was not yet implemented or is not following the accepted standards label Apr 17, 2022
@guispiller guispiller transferred this issue from opentibiabr/otservbr-global Apr 17, 2022
@github-actions github-actions bot added the Status: Pending Test This PR or Issue requires more testing label Apr 17, 2022
@github-actions
Copy link
Contributor

This issue is stale because it has been open 120 days with no activity.

@github-actions github-actions bot added the Stale No activity label Jul 16, 2022
@marcosvf132 marcosvf132 mentioned this issue Aug 5, 2022
Merged
10 tasks
dudantas pushed a commit that referenced this issue Sep 15, 2022
@marcosvf132
[Enhancement] Protocol update to 12.91 (#443)
dfc5df7 
Description:
Update tibia protocol to 12.91, including the following features:
• Timer on rings/amulets.
• Charge number on rings/amulets.
• Npc fix. (Sell/Buy more than 100 items at once)
• Two new depot boxes

Fixes:
• #318
• #386

Client 12.91 download link: https://github.com/dudantas/tibia-client/releases/tag/12.91.12329
dudantas pushed a commit to opentibiabr/otservbr-global that referenced this issue Sep 15, 2022
@guispiller
[Enhancement] Protocol update to 12.91 (#732)
5dae66e 
Description:
Datapack modifications;
• Update datapack items and NPCs to protocol 12.91
• Changed some monster's loot names to ID to avoid conflict
• Inserted some Marapur monsters
• Inserted transform to logics of items
Source modifications;
• Update tibia protocol to 12.91, including the following features:
• Timer on rings/amulets
• Charge number on rings/amulets
• NPC fix. (Sell/Buy more than 100 items at once)
• Two new depot boxes

Fixes:
• opentibiabr/canary#318
• opentibiabr/canary#386

This PR works directly with canary 12.91 commit: opentibiabr/canary@dfc5df7

Client 12.91 download link: https://github.com/dudantas/tibia-client/releases/tag/12.91.12329
luan pushed a commit that referenced this issue Jul 11, 2023
@marcosvf132
[Enhancement] Protocol update to 12.91 (#443)
8025cc0 
Description:
Update tibia protocol to 12.91, including the following features:
• Timer on rings/amulets.
• Charge number on rings/amulets.
• Npc fix. (Sell/Buy more than 100 items at once)
• Two new depot boxes

Fixes:
• #318
• #386

Client 12.91 download link: https://github.com/dudantas/tibia-client/releases/tag/12.91.12329
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Stale No activity Status: Pending Test This PR or Issue requires more testing Type: Missing Content Content that was not yet implemented or is not following the accepted standards
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Enhancement] Protocol update to 12.91 marcosvf132/canary
1 participant
@guispiller