Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console not closing if ran w/o db running #802

Closed
2 of 5 tasks
PeachieDude opened this issue Jan 20, 2023 · 0 comments · Fixed by #807
Closed
2 of 5 tasks

Console not closing if ran w/o db running #802

PeachieDude opened this issue Jan 20, 2023 · 0 comments · Fixed by #807
Labels
Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@PeachieDude
Copy link
Contributor

Priority

Low

Area

  • Datapack
  • Source
  • Map
  • Other

What happened?

some commits before, if you ran 'canary.exe' w/o having the db server running it would give a message and then you could just press any button to close it
(using the new one as example cuz it keeps the message)
[2023-20-01 13:13:58.079] [error] Message: Can't connect to server on '127.0.0.1' (10061)
[2023-20-01 13:13:58.079] [error] Failed to connect to database!
[2023-20-01 13:13:58.080] [error] The program will close after pressing the enter key...

But now, if the same happens it will spam the last message indefinitely.

[2023-20-01 13:13:56.032] [info] Establishing database connection...
[2023-20-01 13:13:58.079] [error] Message: Can't connect to server on '127.0.0.1' (10061)
[2023-20-01 13:13:58.079] [error] Failed to connect to database!
[2023-20-01 13:13:58.080] [error] The program will close after pressing the enter key...
[2023-20-01 13:54:39.618] [info] MySQL Version: 3.3.1
[2023-20-01 13:54:39.618] [info] Running database manager...
[2023-20-01 13:54:39.619] [error] Query: SELECT TABLE_NAME FROM information_schema.tables WHERE TABLE_SCHEMA = 'noname_db'
[2023-20-01 13:54:39.620] [error] Message: Server has gone away
[2023-20-01 13:54:40.632] [error] Query: SELECT TABLE_NAME FROM information_schema.tables WHERE TABLE_SCHEMA = 'noname_db'

it wont close the console. it will just keep giving this message forever and ever

For the matter, my build is updated till #705 and i added #784 to it, didnt update with the latest ones.

What OS are you seeing the problem on?

Windows

Code of Conduct

  • I agree to follow this project's Code of Conduct
@PeachieDude PeachieDude added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jan 20, 2023
@github-actions github-actions bot added Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing labels Jan 20, 2023
@murilo09 murilo09 linked a pull request Jan 20, 2023 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant