[Mac] Explicitly retain/release CocoaWindowInfo instances

opentk · May 14, 2014 · 1419c1e · 1419c1e
1 parent 290cc91
commit 1419c1e
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/Source/OpenTK/Platform/MacOS/Cocoa/Selector.cs b/Source/OpenTK/Platform/MacOS/Cocoa/Selector.cs
@@ -38,6 +38,7 @@ static class Selector
         public static readonly IntPtr Init = Selector.Get("init");
         public static readonly IntPtr InitWithCoder = Selector.Get("initWithCoder:");
         public static readonly IntPtr Alloc = Selector.Get("alloc");
+        public static readonly IntPtr Retain = Selector.Get("retain");
         public static readonly IntPtr Release = Selector.Get("release");
         public static readonly IntPtr Autorelease = Selector.Get("autorelease");
 

diff --git a/Source/OpenTK/Platform/MacOS/CocoaNativeWindow.cs b/Source/OpenTK/Platform/MacOS/CocoaNativeWindow.cs
@@ -1021,7 +1021,7 @@ protected override void Dispose(bool disposing)
                     trackingArea = IntPtr.Zero;
                 }
 
-                Cocoa.SendVoid(windowInfo.Handle, Selector.Release);
+                windowInfo.Dispose();
             }
 
             OnDisposed(EventArgs.Empty);

diff --git a/Source/OpenTK/Platform/MacOS/CocoaWindowInfo.cs b/Source/OpenTK/Platform/MacOS/CocoaWindowInfo.cs
@@ -68,6 +68,7 @@ public CocoaWindowInfo(IntPtr nsWindowRef, IntPtr nsViewRef)
         {
             this.nsWindowRef = nsWindowRef;
             this.nsViewRef = nsViewRef;
+            Cocoa.SendVoid(nsWindowRef, Selector.Retain);
         }
 
         #endregion
@@ -107,16 +108,22 @@ void Dispose(bool disposing)
 
             if (disposing)
             {
-
+                Cocoa.SendVoid(nsWindowRef, Selector.Release);
+            }
+            else
+            {
+                Debug.Print("CocoaWindowInfo:{0} leaked, did you forget to call Dispose()?", nsWindowRef);
             }
 
             disposed = true;
         }
 
+        #if DEBUG
         ~CocoaWindowInfo()
         {
             Dispose(false);
         }
+        #endif
 
         #endregion
     }