Fix bool return types #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GLboolean is typedefed as an unsigned char. It appears that `[return: MarshalAs(UnmanagedType.U1)]` is ignored in calli p/invokes, so we need to take care of this ourselves by emitting byte instead of bool for the p/invoke signature. The public API remains unchanged. Fixes issue #129.
Since GL_TRUE and GL_FALSE match .Net true and false (1 and 0, respectively), we can simply reinterpret the byte value as a bool. In the future, we could issue a `(if value == 0 then false else true)` statement for added safety, but this does not appear to be necessary right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System.Booleanis marshaled as a 4-byte int by default, but GLboolean is typedefed as a 1-byte unsigned char. Calli instructions do not appear to respect[return: MarshalAs(UnmanagedType.U1)], so we need to handle this ourselves by emitting byte instead of bool on the p/invoke signatures.Fixes issue #129