Fix Xamarin project compiles #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maybe we can add these back in later, when we have compiling support for these platforms.
copygirl
suggested changes
Jan 22, 2018
src/OpenTK/OpenTK.iOS.csproj
Outdated
| </Policies> | ||
| </Properties> | ||
| </MonoDevelop> | ||
| </ProjectExtensions> |
There was a problem hiding this comment.
The <ProjectExtensions> block was probably included on accident - remove?
Nihlus
suggested changes
Jan 22, 2018
src/OpenTK/OpenTK.iOS.csproj
Outdated
| </Target> | ||
| <ProjectExtensions> |
There was a problem hiding this comment.
No need to include this. Remove.
| @@ -53,7 +53,14 @@ public AssemblyDefinition Resolve(AssemblyNameReference name, ReaderParameters p | |||
|
|
|||
| var framework_dir = Path.GetDirectoryName(typeof(object).Module.FullyQualifiedName); | |||
| var framework_dirs = on_mono | |||
| ? new[] { framework_dir, Path.Combine(framework_dir, "Facades") } | |||
| ? new[] | |||
There was a problem hiding this comment.
Looks good. I worry that we'll have to maintain our own version of the resolver in the future because of this, though.
|
The project analysis simply takes a long time due to the size of the project. |
Nihlus
approved these changes
Jan 23, 2018
VPeruS
pushed a commit
to VPeruS/opentk
that referenced
this pull request
Jul 8, 2018
* Fix Generator.Rewrite failing on iOS builds * Fix incorrect path * Directly link to Xamarin.iOS facades * Fix Xamarin.Mac framework directory * Add TVOS/WatchOS framework directories * Add Android framework directory * Remove unused framework dirs for now Maybe we can add these back in later, when we have compiling support for these platforms. * Remove ProjectExtensions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
OpenTK.csproj.OpenTK.csproj.Testing status
Comments