Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the aftermath of merging #842 #843

Closed
wants to merge 1 commit into from
Closed

Fix the aftermath of merging #842 #843

wants to merge 1 commit into from

Conversation

Perksey
Copy link
Contributor

@Perksey Perksey commented Nov 2, 2018

@FreezyLemon pointed out to me that ReSharper isn't a very good shot, and didn't catch all of the OpenTK references. I've took it upon myself to sift through all of the usages of OpenTK, and replace them in this wonderful PR. ;)

@Perksey Perksey mentioned this pull request Nov 2, 2018
Merged
@Perksey Perksey changed the title [4.0] Fix the aftermath of merge [4.0] Fix the aftermath of merging #842 Nov 2, 2018
@FreezyLemon
Copy link
Contributor

  1. The most important part is still wrong... all the OpenToolkit.NT types are in wrong namespaces..
  2. The rewriter is still in the OpenTK namespace... Not sure if that was intentional, but I have a feeling it would be a good opportunity to also move that over
  3. The binder still has some old namespace references

@Perksey Perksey changed the title [4.0] Fix the aftermath of merging #842 [4.0] [WIP] Fix the aftermath of merging #842 Nov 3, 2018
@Perksey Perksey changed the title [4.0] [WIP] Fix the aftermath of merging #842 Fix the aftermath of merging #842 Nov 3, 2018
@Perksey Perksey changed the title Fix the aftermath of merging #842 [WIP] Fix the aftermath of merging #842 Nov 3, 2018
@Perksey Perksey closed this Nov 3, 2018
@Perksey Perksey deleted the opentoolkit-ns-aftermath branch January 3, 2019 15:25
@frederikja163 frederikja163 changed the title [WIP] Fix the aftermath of merging #842 Fix the aftermath of merging #842 Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Perksey @FreezyLemon