[4.0] Impliment Vectord * Quaterniond #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Won't be able to merge until blocker PR #843 is merged, to avoid any kerfuffle. |
Perksey
changed the title
|
Should this be targeted to the namespace branch? |
|
I was going to set it back to master following the merge of #843, to avoid any breaks and other slip-ups. |
|
Just realized that all double-precision vector types were missing this operator, not just 4d. Latest commit adds it to 2d and 3d as well. |
devvoid
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vector4 and Quaternion can be multiplied, but the double-precision equivalents can't. This just impliments the * operator for Vector4d and Quaterniond. Closes #678.