OpenAL cleanup #909
Merged
OpenAL cleanup #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ready for review! |
Perksey
suggested changes
May 24, 2019
src/OpenAL/Extensions/OpenTK.OpenAL.Extensions.Creative.EFX/Presets/ReverbPresets.cs
Outdated
Show resolved
Hide resolved
src/OpenAL/Extensions/OpenTK.OpenAL.Extensions.Creative.EFX/Presets/ReverbPresets.cs
Outdated
Show resolved
Hide resolved
Perksey
suggested changes
May 24, 2019
src/OpenAL/Extensions/OpenTK.OpenAL.Extensions.Creative.EFX/Presets/ReverbProperties.cs
Outdated
Show resolved
Hide resolved
src/OpenAL/Extensions/OpenTK.OpenAL.Extensions.EXT.Capture/AudioCapture.cs
Outdated
Show resolved
Hide resolved
src/OpenAL/Extensions/OpenTK.OpenAL.Extensions.EXT.Capture/AudioCapture.cs
Outdated
Show resolved
Hide resolved
src/OpenAL/Extensions/OpenTK.OpenAL.Extensions.EXT.Capture/Capture.cs
Outdated
Show resolved
Hide resolved
|
I do apologize for the seemingly robotic and daunting review. A lot of this PR is predicated on the fact that the format for long method calls is wrong. It is not, ReSharper just says it is because we can't configure the way we do it. I'm pretty confident my review is just asking you to revert your changes with this regard. Speak to @Nihlus for more info regarding this. |
|
It's fine, should've asked before doing it. Fixed everything you commented on. |
|
Will run another pass over this PR, review should be in the next 3 days hopefully. |
Perksey
suggested changes
May 26, 2019
src/OpenAL/Extensions/OpenTK.OpenAL.Extensions.Creative.EFX/Presets/ReverbProperties.cs
Outdated
Show resolved
Hide resolved
src/OpenAL/Extensions/OpenTK.OpenAL.Extensions.EXT.Capture/Capture.cs
Outdated
Show resolved
Hide resolved
|
That should be everything you mentioned |
|
Needs some conflict resolution on your side, then I'll do a final review so we can merge. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I wait for #908 to be finished so I can put the last touches on #867, I'm going to start on a project I've been meaning to get to for a while.
This is going to be a pretty big cleanup of the OpenAL bindings; as of right now, the compiler generates a lot of warnings, and Rider has a bunch of issues with the code style. Once this is over, it should build without any complaints.