Add vector types with integer components. #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varon
requested changes
May 22, 2019
|
Resolved the requested changes, let me know if there's anything else. |
jvbsl
reviewed
May 22, 2019
This was referenced May 23, 2019
Merged
Vassalware
changed the title
varon
reviewed
May 26, 2019
| @@ -0,0 +1,544 @@ | |||
| // | |||
| // Vector3i.cs | |||
There was a problem hiding this comment.
Minor, but why are we repeating the file name in the comments? That seems really pointless.
There was a problem hiding this comment.
Good catch, that should be Vector2i. As a big picture discussion point, not a clue. Jax is the one to talk to about that.
| /// <param name="a">Left operand.</param> | ||
| /// <param name="b">Right operand.</param> | ||
| /// <returns>Result of operation.</returns> | ||
| public static Vector2i Add(Vector2i a, Vector2i b) |
There was a problem hiding this comment.
Can we annotate by-value methods with the Pure attribute?
This is something to look at for the rest of the vector/math library.
varon
approved these changes
May 26, 2019
|
Well done and thanks for this very cool contribution, @Vassalware ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The discussion in the discord led to the conclusion that
Vectortypes with integer components should be added toOpenToolkit.Mathematics.