Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Int vectors in windows #917

Merged
merged 4 commits into from
May 30, 2019
Merged

Int vectors in windows #917

merged 4 commits into from
May 30, 2019

Conversation

devvoid
Copy link
Contributor

@devvoid devvoid commented May 28, 2019

Purpose of this PR

  • At the time of the GLFW PR, there weren't any int vectors, so the windows had to use float vectors that were cast to ints when passed to GLFW. Now that int vectors are in master, this makes the windows use them instead.
  • Affects Windowing.
  • No additional documentation necessary.

Testing status

  • It builds.

Comments

  • No other comments.

@devvoid devvoid mentioned this pull request May 28, 2019
Merged
@devvoid
Copy link
Contributor Author

devvoid commented May 28, 2019

Currently blocked by #918

@devvoid devvoid changed the title [WIP] Int vectors in windows Int vectors in windows May 29, 2019
@devvoid
Copy link
Contributor Author

devvoid commented May 29, 2019

This is ready for review.

@varon varon merged commit f02ec40 into opentk:master May 30, 2019
@devvoid devvoid deleted the vector2i_in_windows branch May 30, 2019 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvbsl jvbsl jvbsl left review comments

@frederikja163 frederikja163 frederikja163 left review comments

@varon varon varon approved these changes

@Perksey Perksey Perksey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@devvoid @varon @Perksey @jvbsl @frederikja163