Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Box2i support #918

Merged
merged 4 commits into from
May 29, 2019
Merged

Box2i support #918

merged 4 commits into from
May 29, 2019

Conversation

devvoid
Copy link
Contributor

@devvoid devvoid commented May 28, 2019 •
edited
Loading

Purpose of this PR

  • While working on Int vectors in windows #917, I realized that it also needs support for integer boxes. This small PR aims to add them.
  • Affects Mathematics.
  • No additional documentation required.

Testing status

  • No testing beyond it building.

Comments

  • This will also contain some very small improvements to Box2, like using optional parameters instead of overloads, and using MathHelper.ApproximatelyEqual instead of direct comparisons.

@devvoid devvoid mentioned this pull request May 28, 2019
Merged
@devvoid devvoid changed the title [WIP] Box2i support Box2i support May 28, 2019
@devvoid
Copy link
Contributor Author

devvoid commented May 28, 2019

@varon @Nihlus @Perksey This is ready for review whenever you're available.

@Perksey Perksey merged commit 2793286 into opentk:master May 29, 2019
@devvoid devvoid deleted the box2i branch May 30, 2019 21:30
@frederikja163 frederikja163 mentioned this pull request Jun 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Perksey Perksey Perksey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@devvoid @Perksey