Box tests #926
Box tests #926
Conversation
| _max.Y = value.Y; | ||
| } | ||
|
|
||
| _max = value; |
There was a problem hiding this comment.
why? that changes the meaning?
If I have a Box e.g. Box2(0,0,5,5)
and set min to (0,10)
Box2 will be (0,10,5,10), therefore it having Height of zero.
I would expect it to be similar to the rubberband rectangle in e.g. paint. If you drag the minimal value over to the other side, it will automatically set the max value automatically...
There was a problem hiding this comment.
There was a problem hiding this comment.
Excellent work @frederikja163 . Nicely written tests and great coverage.
|
|
||
| [<Property>] | ||
| let ``The distance should never be negative`` (b1 : Box3, v1 : Vector3) = | ||
| Assert.True(b1.DistanceToNearestEdge(v1) >= (float32)0) |
There was a problem hiding this comment.
Minor, but it's preferable to use a float literal here. 0.0f
| [<Properties(Arbitrary = [|typeof<OpenTKGen>|])>] | ||
| module Equality = | ||
| [<Property>] | ||
| let ``Any box should be equal to itself`` (b1 : Box3) = |
There was a problem hiding this comment.
Whenever we test equality, always a good idea to test hashcode too.
|
|
||
| b.Size <- v1 | ||
|
|
||
| Assert.Equal(b1.Size/(float32)2, b1.HalfSize) |
There was a problem hiding this comment.
Using literals is preferable to converting. 2 -> 2.0f
| @@ -370,7 +288,7 @@ public override int GetHashCode() | |||
| /// <inheritdoc/> | |||
| public override string ToString() | |||
| { | |||
| return $"({Min.X}{ListSeparator} {Min.Y}) - ({Max.X}{ListSeparator} {Max.Y})"; | |||
| return $"({Min.X}{ListSeparator} {Min.Y}{ListSeparator} {Min.Z}) - ({Max.X}{ListSeparator} {Max.Y}{ListSeparator} {Max.Z})"; | |||
There was a problem hiding this comment.
Probably not necessary to use an explicit ListSeparator.
Purpose of this PR
Comments