Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input parameters of passwords and private keys are visible in the UI #21

Open
nyuuyn opened this issue Mar 19, 2018 · 0 comments
Open

Comments

@nyuuyn
Copy link
Contributor

nyuuyn commented Mar 19, 2018

Current Behavior:
In some older version parameters which represented passwords (e.g. DBMSPassword) the input field hid the value (e.g. pw is shown as: ********).

Additionally, in older version if a parameter was a PrivateKey (e.g. VMPrivateKey) the input field didn't mess up the PrivateKey from a string perspective (e.g. the private key is broken and can't be used by some artefacts such as the SSH service for virtual machines)

Expected Behavior:
Password parameter values are hidden, PrivateKeys are still valid after pasting them into the field.

Steps to Reproduce:

  1. Use any CSAR (e.g. MyTinyTodo with MySQL) which has atleast one Password Parameter
  2. Use any CSAR which has a PrivateKey Input Parameter

Other Information:
Params not beeing hidden or well formatted:

screen shot 2018-03-19 at 14 51 39

Some logs when the private key is really needed:

screen shot 2018-03-19 at 14 51 18 2

P.S.: I know we can just escape the returns, but well, does it have to be done?! :P

System Information:
Mac OS X with Docker Setup and Chrome

@nyuuyn nyuuyn added the bug label Mar 19, 2018
@miwurster miwurster changed the title [BUG] Input parameters of Passwords and PrivateKeys Input parameters of passwords and private keys are visible in the UI Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants