Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I want to provide the following changes to VB version. #105

Closed
daisukenishino opened this issue Jul 13, 2015 · 8 comments · Fixed by #115
Closed

I want to provide the following changes to VB version. #105

daisukenishino opened this issue Jul 13, 2015 · 8 comments · Fixed by #115
Labels
enhancement New feature or request

Comments

@daisukenishino
Copy link
Contributor

Requirement

I want to provide the following changes to VB version.

(1)

  • Changes to the JS file
  • I've already merged.

(2)

(3)

  • jQGrid + WCF(JSON.NET)
    This is provided against edition of more than root_VS2010, because it require .NET v4.0.

(4)

AsyncProcessingService :

  • Infrastructure.Business.AsyncProcessingService
  • ServiceInterface.AsyncProcessingService
  • Sample.AsyncProcessingService

note : I aborted the VB migration of ServiceInterface.AsyncProcessingService.
Therefor, There is no need to migrate ServiceInterface.AsyncProcessingService to VB.

@daisukenishino daisukenishino added the enhancement New feature or request label Jul 13, 2015
@supragyan
Copy link
Contributor

@daisukenishino

I want to provide the following changes to VB version.
Sample code of text change event on testScreen2.aspx ( + app.config).

We have already completed this task and committed earlier.
We did check it has been merged by @daisukenishino to "/OpenTouryoProject/OpenTouryo/develop/" branch as https://github.com/SymphonyTeleca/OpenTouryo/pull/55#event-363172599

Please let us know what is pending.

jQGrid + WCF(JSON.NET)

Do we need to commit the jQGrid + WCF(JSON.NET) in vb.net changes in all the root(root_VS2010, root_VS2012, root_VS2013) of "SymphonyTeleca/OpenTouryoTemplates/" ?

Because as we checked it seems "jQGrid + WCF(JSON.NET) in c# .net changes placed in all the root branches(root_VS2010, root_VS2012, root_VS2013) of ("/OpentouryoProject/OpenTouryoTemplates/")"

Please confirm

@daisukenishino
Copy link
Contributor Author

@supragyan

Please let us know what is pending.

  • (1) and (2) tasks are already completed.
  • (3) and (4) tasks are not completed.

Please confirm

Please change the root_VS2010.

The task that reflect the changes of root_VS2010 to root_VS2012 & root_2013, it will perform at the "marge task". "marge task" will be carried out at the end of the previous fiscal year.

@supragyan
Copy link
Contributor

@daisukenishino
Thank you for confirmation.

(1) and (2) tasks are already completed.

Yes it is completed.

(3) and (4) tasks are not completed.

Task (4) is handling by @SandeepNayak077
He will start this task after completed the 'Construction of VM document'.

In Task(3),

Please change the root_VS2010.
The task that reflect the changes of root_VS2010 to root_VS2012 & root_2013, it will perform at the "marge task". "marge task" will be carried out at the end of the previous fiscal year.

We will commit jQGrid + WCF(JSON.NET) changes to root_VS2010. of "/SymphonyTeleca/OpenTouryoTemplates/"

Is this ok?
Please confirm.

@daisukenishino
Copy link
Contributor Author

@supragyan

Is this ok.

OK.
Changes of "/root_VS2010/programs/C#/" should be reflect to "/root_VS2010/programs/VB/".

@supragyan
Copy link
Contributor

@daisukenishino

Changes of "/root_VS2010/programs/C#/" should be reflect to "/root_VS2010/programs/VB/".

Thank you for the confirmation.
We will test and take care that it should be reflected as same as in the C#.

@SandeepNayak077
Copy link
Contributor

@daisukenishino

We missed the following modification in the previous commit of (C#)

We will commit the above modification while creating pull request of migration of VB code.
Shall we commit above modification? Please confirm.

Migration to VB is completed.
We are in the process of review and testing.
We will deliver the changes by tomorrow (16-Sep-2015).
Please confirm.

Sorry for the inconvenience caused by the above code commit.
In future we will take care of it.

@daisukenishino
Copy link
Contributor Author

@SandeepNayak077

Shall we commit above modification?

Please send one pullrequest that collected these fixes.

Migration to VB is completed.

Do you also completed the (4) task?

@SandeepNayak077
Copy link
Contributor

@daisukenishino

Do you also completed the (4) task?

Yes, we have completed the migration process.
Internal code review and testing are under process.
We will deliver it by today EOD.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants