Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Span customization - Extend WebFluxSpanDecorator #140

Open
NHebrard opened this issue Dec 14, 2020 · 1 comment
Open

Span customization - Extend WebFluxSpanDecorator #140

NHebrard opened this issue Dec 14, 2020 · 1 comment

Comments

@NHebrard
Copy link
Contributor

Hello!

I need to customize a span right after its creation and before its activation (injecting some baggage items).

I am encountering this need for both regular Servlet based applications and WebFlux applications.

In the Servlet world, it’s totally feasible thanks to a ServletFilterSpanDecorator.onRequest() which is invoked right after the span creation and before its activation.
See TracingFilter.

However, it’s not achievable in the reactor world as the WebFluxSpanDecorator.onRequest() is actually called at the subscription time occurring after the span activation.
See TracingOperator and TracingSubscriber.

Could we extend the WebFluxSpanDecorator by adding a new callback onCreate() that would be called right after the span creation?
I would also remove This is called right after span in created from the onRequest() documentation as it's not really the case.

Let me know if you agree with the proposal, I'll be happy to contribute! :)

@geoand
Copy link
Collaborator

geoand commented Dec 14, 2020

Hi,

That sounds good to me! Feel free to contribute :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants