Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should client interceptor use more information for generating operation name? #47

Closed
elgris opened this issue Dec 4, 2017 · 1 comment

Comments

@elgris
Copy link

elgris commented Dec 4, 2017

Currently client interceptor uses only method of request as an operation name for new spans:

ActiveSpan span = tracer.buildSpan(httpRequest.getMethod().toString())
                .withTag(Tags.SPAN_KIND.getKey(), Tags.SPAN_KIND_CLIENT).startActive();

Does it make sense to add a request path to operation name? Or maybe make an operation name generator to support customisation of that? Otherwise for many outgoing GET requests to different targets, spans appear with the same operation name GET.

@pavolloffay
Copy link
Collaborator

Span can be modified via decorators. Path should not be used as operation name due to cardinality problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants