Skip to content
This repository has been archived by the owner on May 23, 2023. It is now read-only.

Fix lint and coverage #202

Merged
merged 3 commits into from
Nov 29, 2018
Merged

Fix lint and coverage #202

merged 3 commits into from
Nov 29, 2018

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Nov 29, 2018

Problem

  • The old go get -u github.com/golang/lint/... no longer works
  • The new go get -u golang.org/x/lint/golint/... does not work in older Go versions (it uses type alias)
  • Coverage was never uploaded

Fixes

  • Use Travis build matrix with env vars to control LINT and COVERAGE
  • Only run lint and coverage on tip, not on older versions

Yuri Shkuro added 2 commits November 29, 2018 11:35
Signed-off-by: Yuri Shkuro <ys@uber.com>
…ckage coverage

Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
@codecov-io
Copy link

codecov-io commented Nov 29, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@6b6f234). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #202   +/-   ##
=========================================
  Coverage          ?   58.74%           
=========================================
  Files             ?       14           
  Lines             ?      829           
  Branches          ?        0           
=========================================
  Hits              ?      487           
  Misses            ?      302           
  Partials          ?       40

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b6f234...a7d1910. Read the comment docs.

.idea/
opentracing-go.iml
opentracing-go.ipr
opentracing-go.iws
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these should go to user's global gitignore

@yurishkuro yurishkuro merged commit f6bb0d0 into master Nov 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants