Skip to content
This repository has been archived by the owner on May 23, 2023. It is now read-only.

edit OT-JS license info so that GitHub recognizes it #105

Merged
merged 1 commit into from
Sep 10, 2018

Conversation

eirinikos
Copy link
Contributor

(All CNCF projects should use the Apache License 2.0 - see opentracing/specification#61 for context.)

  • Please correct me if I'm wrong, but it seems like the original intent was to license OT-JavaScript as Apache 2.0, anyway (as mentioned in the README).
  • However, the LICENSE file itself contains the text for the MIT License, and a copyright reference to 2016 Resonance Labs, Inc.
  • In any case, GitHub currently detects the OT-JavaScript license as MIT, not Apache 2.0.
  • Could someone clarify the reason for referencing the Apache license in README and using the MIT license in the LICENSE file?

If this commit really does represent a switch from MIT to Apache, then we'd like to give previous contributors a 7-day period to air any objections.

(If you have any concerns or feedback, please post a comment here by April 11. Thanks!)

CCing @dankohn @bhs

CCing previous contributors: @bcronin @oibe @yurishkuro @bripkens @skzinc @felixfbecker @rochdev @eli-jordan @aroc @AloisReitbauer @jhorowitz @strongliang

GitHub uses a library called Licensee to identify a project's license
type. It shows this information in the status bar and via the API if it
can unambiguously identify the license.

This commit replaces the contents of the LICENSE file with the text
of the Apache 2.0 license (Copyright The OpenTracing Authors). It also
updates package.json to refer to the Apache license. This allows
Licensee's license type identification (as Apache 2.0) to succeed.

Signed-off-by: Andrea Kao <eirinikos@gmail.com>
@coveralls
Copy link

coveralls commented Apr 4, 2018

Coverage Status

Coverage remained the same at 88.525% when pulling 5130827 on eirinikos:update-license into 3abef18 on opentracing:master.

@felixfbecker
Copy link
Contributor

Note that package.json also declares MIT as license.

Copy link
Contributor

@bhs bhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me (as you know). Let's wait the requisite amount of time, etc, but thanks!

@austinlparker
Copy link
Member

This has been sitting for a while with the appropriate approvals and no feedback to the negative, so I'll go ahead and merge it.

@austinlparker austinlparker merged commit 22e7fea into opentracing:master Sep 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants