Skip to content
This repository has been archived by the owner on May 23, 2023. It is now read-only.

Fix typo in compatibility snippet #81

Merged
merged 2 commits into from
Apr 26, 2017
Merged

Fix typo in compatibility snippet #81

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ab7da9
Fix typo in compatibility snippet
DanielMSchmidt Apr 26, 2017
741574b
Fix import to named import in example snippet
DanielMSchmidt Apr 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,8 @@ Implementations can subclass `opentracing.Trace`, `opentracing.Span`, and the ot
If `mocha` is being used for unit testing, `test/api_compatibility` can be used to test the custom tracer. The file exports a single function that expects as an argument a function that will return a new instance of the tracer.

```javascript
const apiCompatibilityChecks = require('opentracing/lib/test/api_compatibility.js');
apiCompatibilityCheck(() => new CustomTracer());
const { apiCompatibilityChecks } = require('opentracing/lib/test/api_compatibility.js');
apiCompatibilityChecks(() => new CustomTracer());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

according to #78, this is also missing .default after require(), could you add it? Then I can merge.

Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may do both, as it both an named and a default export. Shall I still change it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

People claim it does not work without .default in some later versions (of Babel?). I am not an expert in JS ecosystem. I will merge as is, you may want to reply to that other ticket.

```

### MockTracer
Expand Down