Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decimal entry is difficult in V2 / Logical Switches #5375

Closed
capitaineflam25 opened this issue Nov 16, 2017 · 4 comments
Closed

Decimal entry is difficult in V2 / Logical Switches #5375

capitaineflam25 opened this issue Nov 16, 2017 · 4 comments

Comments

@capitaineflam25
Copy link

capitaineflam25 commented Nov 16, 2017

Companion 2.2.1N436 / Taranis X7

Language of the test computer is French (decimal separator is ",")

  • Add a Volt telemetry sensor, name it A1, with precision 1
  • Go to logical Switches and add a line
  • Select "a<x", then "TELE1:A1"
  • Select v2 content so you can replace it
  • Type 12,1 with the keyboard you should get "12,0 V"

There is no issue with other decimal fields, it may be linked to the presence of the unit ? (The unit is refreshed after each keypress)

(This is a cosmetic issue, you can then select the value after the coma and replace it)

image

@capitaineflam25
Copy link
Author

I don't know if the "Duration" field is based on the same doublespin box.
The issue is not reproduced on it.
I was wondering if the "bad" behaviour was due to the unit append at the end of the value.

image

@kilrah
Copy link
Member

kilrah commented Nov 19, 2017

Ah no, it's much more complex than that - since the values and steps that may be stored in an LS may not match what can be entered in the V2 box everytime that's edited we have to convert the value to what can be stored, then set the box back to the actual value. That overwrites what you just typed and cancels editing.

I don't see a way to improve that with reasonable complexity.

@capitaineflam25
Copy link
Author

Ok thanks for the explanation.
It maybe better to leave it as is.
I let you decide if you prefer leaving the suggestion open or closed.

mpaperno added a commit that referenced this issue Nov 28, 2017
… refresh (fixes #5374); Improve data entry in spin boxes (fixes #5375).
mpaperno added a commit that referenced this issue Dec 18, 2017
… refresh (fixes #5374); Improve data entry in spin boxes (fixes #5375).
bsongis pushed a commit that referenced this issue Dec 19, 2017
…#5437)

* [Companion] RawSourceRange: Fix for timers and RTC; Remove unused "single precision" flag and logic; Add logic for "short" timer handling.

* [Companion] Add TimerEdit class for editing negative times; Implement TimerEdit in LS, CF, and Telemetry (bars) editors;

* [Companion] Refactor LogicalSwitchesPanel for fewer & more efficient updates; Fix newly-added LS not being available in source lists; Fix bug with timer/rtc comparison values getting reset to value of spin box instead of time editor.

* Add forgotten #include.

* [Companion] LogicalSwitchesPanel: Update raw sources list upon screen refresh (fixes #5374); Improve data entry in spin boxes (fixes #5375).

* Make gcc happy.

* [Companion] Set proper RawSourceRange for GVars, trims, mixer scripts, and sticks/switches/cyclic/MAX.

* [Companion] Fix backwards precision/range logic on telemetry sensors offset spinbox; Fix other minor range issues with ratio & offset.

* [Companion] Remove short limit on min/max timer values for LS & telem. bars.

* Switch to TimerEdit in maxLibQt.

* Fix gcc build.

* Remove unused files.

* Caps fix.
mr-pokryshkin pushed a commit to mr-pokryshkin/opentx that referenced this issue Dec 19, 2017
…opentx#5437)

* [Companion] RawSourceRange: Fix for timers and RTC; Remove unused "single precision" flag and logic; Add logic for "short" timer handling.

* [Companion] Add TimerEdit class for editing negative times; Implement TimerEdit in LS, CF, and Telemetry (bars) editors;

* [Companion] Refactor LogicalSwitchesPanel for fewer & more efficient updates; Fix newly-added LS not being available in source lists; Fix bug with timer/rtc comparison values getting reset to value of spin box instead of time editor.

* Add forgotten #include.

* [Companion] LogicalSwitchesPanel: Update raw sources list upon screen refresh (fixes opentx#5374); Improve data entry in spin boxes (fixes opentx#5375).

* Make gcc happy.

* [Companion] Set proper RawSourceRange for GVars, trims, mixer scripts, and sticks/switches/cyclic/MAX.

* [Companion] Fix backwards precision/range logic on telemetry sensors offset spinbox; Fix other minor range issues with ratio & offset.

* [Companion] Remove short limit on min/max timer values for LS & telem. bars.

* Switch to TimerEdit in maxLibQt.

* Fix gcc build.

* Remove unused files.

* Caps fix.
@capitaineflam25
Copy link
Author

Thanks a lot, the new editor is way better !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants