Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
[Companion] Adjust source value ranges and editors in LS/CF/Telemetry #5437
Went down a rabbit hole with regards to timer and RTC ranges and how they're used/limited/edited in regards to LS (comparison functions), CF (set timerN action), and telemetry display bar limits. Seems there's a bit of confusion here both in Companion and on radio (probably due to legacy issues).
There are some issues/questions on the firmware side... I found a couple small bugs and will open a separate PR and bring them up there.
But the main question is why the limit of +/- 23m59s on timer values for LS comparison functions and telem. bar display min/max since the variable types (in firmware) can handle a lot more than that.
I think it was a limit somewhere on 9X Stock AVR at least at some point...
referenced this pull request
Nov 30, 2017
This PR relates to #5445 and should be merged together. I wasn't really sure if it was clearer to separate them or put them both together.
Removed the short limits on timer values.