Interchangeable between ucc_status_t and ucs_status_t?

[kingchc]

My compiler (clang with -Wenum-conversion) is complaining the following:

third-party/ucc/src/components/mc/cuda/mc_cuda.c:187:9: error: implicit conversion from enumeration type 'ucs_status_t' to different enumeration type 'ucc_status_t' [-Werror,-Wenum-conversion]
        CUDADRV_FUNC(cuDeviceGetAttribute(&mem_ops_attr,
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
third-party/ucc/src/components/mc/cuda/mc_cuda.h:116:32: note: expanded from macro 'CUDADRV_FUNC'
        ucc_status_t _status = UCS_OK;
                     ~~~~~~~   ^~~~~~

It looks like a typo to me:

ucc/src/components/mc/cuda/mc_cuda.h

Line 116 in d13e395

ucc_status_t _status = UCS_OK; \

Another similar variable in TL NCCL:

ucc/src/components/tl/nccl/tl_nccl_team.c

Line 135 in d13e395

ucs_status_t status;

Just wanted to check if ucc_status_t and ucs_status_t is Interchangeable since they are slightly different in my understanding. Is ucs_status_t a superset of ucc_status_t?

cc @Sergei-Lebedev

[Sergei-Lebedev]

Hi @kingchc, this is a bug. In general ucc_status_t is not interchangeable with ucs_status_t, only for positive statuses.
Will fix and add clang option to our tests, , thanks for reporting.

[Sergei-Lebedev]

Fixed in v0.1.x release branch. For master branch there is similar PR but with more changes #171

[vspetrov]

@Sergei-Lebedev can we close?