Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPI-style INPLACE operations #683

Open
vspetrov opened this issue Nov 29, 2022 · 2 comments
Open

MPI-style INPLACE operations #683

vspetrov opened this issue Nov 29, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@vspetrov
Copy link
Collaborator

MPI and UCC define INPLACE support differently for some operations. For example, for REDUCE_SCATTER (V):
At rank "I" UCC places the result of reduction at the rank's I offset = rcount * i * dt_size from the beginning of the buffer, while MPI puts the result at offset = 0 (directly in the beginning) for all ranks. Same for RSV.

NOTE, for Scatter, Scatterv this is not the case because MPI defines INPLACE in UCC style for those ops. Ie, the data at root is never moved for "self" in case of INPLACE.

So, we want to add support for MPI style INPLACE for RS and RSV collectives. Proposal (discussed long ago): add the coll_args flag UCC_COLL_ARGS_FLAG_RS_INPLACE_MPI.
Once support added, need to add the check for new API at ompi/coll/ucc/

@janjust janjust added the enhancement New feature or request label Oct 3, 2024
@janjust
Copy link
Collaborator

janjust commented Oct 3, 2024

@MamziB , can you spend some time on this when you get cycles please

@janjust
Copy link
Collaborator

janjust commented Oct 3, 2024

@manjugv related to some other work we've been doing, wanted to see your take on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants