Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page title element missing from the Open UI website #61

Closed
d2s opened this issue Mar 31, 2020 · 1 comment
Closed

Page title element missing from the Open UI website #61

d2s opened this issue Mar 31, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@d2s
Copy link

d2s commented Mar 31, 2020 •
edited
Loading

<head> section of the HTML documents on the open-ui.org website lacks <title> element.

Even while seo.js component has a title={title} in it,
for some reason it does not get rendered to the HTML output.

        return (
          <Helmet
            htmlAttributes={{
              lang,
            }}
            title={title}  // NOTE: this element is missing

In any case, rest of the sites feels fast & usable. 👍
@gregwhitworth gregwhitworth added the bug Something isn't working label Apr 1, 2020
@gregwhitworth
Copy link
Member

This is done, thanks for filing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@d2s @gregwhitworth