Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update popover.research.explainer.mdx #654

Merged
merged 2 commits into from
Jan 20, 2023
Merged

Conversation

jh3y
Copy link
Collaborator

@jh3y jh3y commented Jan 20, 2023

  • Adds a note about being mindful of stylesheets that you haven't authored directly in case they interfere with display values (Mentioned in Normalize css vs popover #650)
  • Removes mention of defaultopen
  • Changes events section to detail beforetoggle and how it works

Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>
@andrico1234 andrico1234 merged commit b529909 into openui:main Jan 20, 2023
gregwhitworth added a commit that referenced this pull request Feb 27, 2023
* initial astro commit

* minor config change

* move over sources

* fix prettier formatting

* rename files and create layout

* move to markdown

* migrate markdown file

* get navigation working

* fix routing for pages

* update the documentation

* more fixes to styling

* get layouts working for all pages

* improve styles even more

* get build working

* fix image

* fix navigation order

* get navigation working

* add favicon

* fix page title

* fix menu sorting

* fix lighthouse issues

* update node version

* minors to styles

* override gatsby build config

* typo

* fix navigation styles

* remove unused dependencies, remove render blocking resources, prefetch resources

* reduce font flashing, fix markup issues

* fix build from breaking

* test removing prefetch

* rmeove compression

* revert changes to config

* fix prefetch

* fix image paths

* Create 2022-12-01.md

* Update 2022-12-01.md

* Update 2022-12-01.md

* Update popup.research.explainer.mdx (#644)

Remove lingering mention of `popover=hint` for now.

* Popover target attribute updates (#647)

The `popovertoggletarget`, `popovershowtarget` and `popoverhidetarget` attributes will initially map to `aria-expanded`.

This has already been implemented in Chromium browsers.  HTML AAM PR to add this mapping to the spec: w3c/html-aam#446

* Create 2023-01-05.md

* Update 2023-01-05.md

* Create 2023-01-12.md

* docs: add kolibri accessible component lib (#624)

* Update 2023-01-12.md

* Create 2023-01-19.md

* Task: Add redirect for popup (#653)

* add redirect for popup

* refactor code

* let yarn do its thing

* revert formatting change

* add redirect comment

Co-authored-by: Andrico <andrico@animaapp.com>

* Update popover.research.explainer.mdx (#654)

* Update popover.research.explainer.mdx

* Update research/src/pages/popup/popover.research.explainer.mdx

Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>

Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>

* Create 2023-02-02.md

* fix layout issue

* fix interactions

* Update 2023-02-02.md

* Update 2023-02-02.md

* selectmenu is an element, code escape it (#660)

* update layout and remove stale content

* handle missing images

* minor fixes and redirects

* fix dead links

* Create 2023-02-16.md

* Update 2023-02-16.md

* Adjusted the home page to reflect the current reality and ensure the relationship between Open UI & the W3C is clear (#663)

* Create 2023-02-23.md

* minor improvements

* temporarily prevent refetch

* revert prefetch change

* Update 2023-02-23.md

* performance + a11y improvements

* remove Lora font family

---------

Co-authored-by: Andrico <andrico.karoulla@healthhero.com>
Co-authored-by: Greg Whitworth <865244+gregwhitworth@users.noreply.github.com>
Co-authored-by: Jhey Tompkins <jh3y@users.noreply.github.com>
Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>
Co-authored-by: Martin <6279703+deleonio@users.noreply.github.com>
Co-authored-by: Andrico <andrico@animaapp.com>
Co-authored-by: Tantek Çelik <blog@tantek.com>
gregwhitworth added a commit that referenced this pull request Feb 28, 2023
* [Site rewrite] Migrate site to astro (#606)

* initial astro commit

* minor config change

* move over sources

* fix prettier formatting

* rename files and create layout

* move to markdown

* migrate markdown file

* get navigation working

* fix routing for pages

* update the documentation

* more fixes to styling

* get layouts working for all pages

* improve styles even more

* get build working

* fix image

* fix navigation order

* get navigation working

* add favicon

* fix page title

* fix menu sorting

* fix lighthouse issues

* update node version

* minors to styles

* override gatsby build config

* typo

* fix navigation styles

* remove unused dependencies, remove render blocking resources, prefetch resources

* reduce font flashing, fix markup issues

* fix build from breaking

* test removing prefetch

* rmeove compression

* revert changes to config

* fix prefetch

* fix image paths

* Create 2022-12-01.md

* Update 2022-12-01.md

* Update 2022-12-01.md

* Update popup.research.explainer.mdx (#644)

Remove lingering mention of `popover=hint` for now.

* Popover target attribute updates (#647)

The `popovertoggletarget`, `popovershowtarget` and `popoverhidetarget` attributes will initially map to `aria-expanded`.

This has already been implemented in Chromium browsers.  HTML AAM PR to add this mapping to the spec: w3c/html-aam#446

* Create 2023-01-05.md

* Update 2023-01-05.md

* Create 2023-01-12.md

* docs: add kolibri accessible component lib (#624)

* Update 2023-01-12.md

* Create 2023-01-19.md

* Task: Add redirect for popup (#653)

* add redirect for popup

* refactor code

* let yarn do its thing

* revert formatting change

* add redirect comment

Co-authored-by: Andrico <andrico@animaapp.com>

* Update popover.research.explainer.mdx (#654)

* Update popover.research.explainer.mdx

* Update research/src/pages/popup/popover.research.explainer.mdx

Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>

Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>

* Create 2023-02-02.md

* fix layout issue

* fix interactions

* Update 2023-02-02.md

* Update 2023-02-02.md

* selectmenu is an element, code escape it (#660)

* update layout and remove stale content

* handle missing images

* minor fixes and redirects

* fix dead links

* Create 2023-02-16.md

* Update 2023-02-16.md

* Adjusted the home page to reflect the current reality and ensure the relationship between Open UI & the W3C is clear (#663)

* Create 2023-02-23.md

* minor improvements

* temporarily prevent refetch

* revert prefetch change

* Update 2023-02-23.md

* performance + a11y improvements

* remove Lora font family

---------

Co-authored-by: Andrico <andrico.karoulla@healthhero.com>
Co-authored-by: Greg Whitworth <865244+gregwhitworth@users.noreply.github.com>
Co-authored-by: Jhey Tompkins <jh3y@users.noreply.github.com>
Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>
Co-authored-by: Martin <6279703+deleonio@users.noreply.github.com>
Co-authored-by: Andrico <andrico@animaapp.com>
Co-authored-by: Tantek Çelik <blog@tantek.com>

* remove unused dependencies

---------

Co-authored-by: Andrico <karoulla.andrico@gmail.com>
Co-authored-by: Andrico <andrico.karoulla@healthhero.com>
Co-authored-by: Jhey Tompkins <jh3y@users.noreply.github.com>
Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>
Co-authored-by: Martin <6279703+deleonio@users.noreply.github.com>
Co-authored-by: Andrico <andrico@animaapp.com>
Co-authored-by: Tantek Çelik <blog@tantek.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants