Adds proposed popover and related attributes #446
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://open-ui.org/components/popup.research.explainer and https://github.com/w3c/html-aam/wiki/HTML-Popover-Attribute-A11y-Proposal-(manual-and-auto) Adds the following proposed attributes: - `defaultopen` - `popover` - `popoverhidetarget` - `popovershowtarget` - `popovertoggletarget`
scottaohara
commented
Nov 28, 2022
I failed to remember this was not being included in v1 of `popover`, so taking this out of the PR.
mfreed7
reviewed
Nov 28, 2022
scottaohara
added a commit
to scottaohara/open-ui
that referenced
this pull request
Dec 11, 2022
The `popovertoggletarget`, `popovershowtarget` and `popoverhidetarget` attributes will initially map to `aria-expanded`. This has already been implemented in Chromium browsers. HTML AAM PR to add this mapping to the spec: w3c/html-aam#446
|
TODOs to complete this PR:
|
andrico1234
pushed a commit
to openui/open-ui
that referenced
this pull request
Dec 13, 2022
The `popovertoggletarget`, `popovershowtarget` and `popoverhidetarget` attributes will initially map to `aria-expanded`. This has already been implemented in Chromium browsers. HTML AAM PR to add this mapping to the spec: w3c/html-aam#446
|
It might be good to wait for whatwg/html#8894. Also, I'm glad this work is already underway! Next time we add new semantics to HTML I'll try to make sure this is considered as part of the main HTML PR. As in, ensure the work is coordinated and can land around the same time. |
gregwhitworth
added a commit
to openui/open-ui
that referenced
this pull request
Feb 27, 2023
* initial astro commit * minor config change * move over sources * fix prettier formatting * rename files and create layout * move to markdown * migrate markdown file * get navigation working * fix routing for pages * update the documentation * more fixes to styling * get layouts working for all pages * improve styles even more * get build working * fix image * fix navigation order * get navigation working * add favicon * fix page title * fix menu sorting * fix lighthouse issues * update node version * minors to styles * override gatsby build config * typo * fix navigation styles * remove unused dependencies, remove render blocking resources, prefetch resources * reduce font flashing, fix markup issues * fix build from breaking * test removing prefetch * rmeove compression * revert changes to config * fix prefetch * fix image paths * Create 2022-12-01.md * Update 2022-12-01.md * Update 2022-12-01.md * Update popup.research.explainer.mdx (#644) Remove lingering mention of `popover=hint` for now. * Popover target attribute updates (#647) The `popovertoggletarget`, `popovershowtarget` and `popoverhidetarget` attributes will initially map to `aria-expanded`. This has already been implemented in Chromium browsers. HTML AAM PR to add this mapping to the spec: w3c/html-aam#446 * Create 2023-01-05.md * Update 2023-01-05.md * Create 2023-01-12.md * docs: add kolibri accessible component lib (#624) * Update 2023-01-12.md * Create 2023-01-19.md * Task: Add redirect for popup (#653) * add redirect for popup * refactor code * let yarn do its thing * revert formatting change * add redirect comment Co-authored-by: Andrico <andrico@animaapp.com> * Update popover.research.explainer.mdx (#654) * Update popover.research.explainer.mdx * Update research/src/pages/popup/popover.research.explainer.mdx Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com> Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com> * Create 2023-02-02.md * fix layout issue * fix interactions * Update 2023-02-02.md * Update 2023-02-02.md * selectmenu is an element, code escape it (#660) * update layout and remove stale content * handle missing images * minor fixes and redirects * fix dead links * Create 2023-02-16.md * Update 2023-02-16.md * Adjusted the home page to reflect the current reality and ensure the relationship between Open UI & the W3C is clear (#663) * Create 2023-02-23.md * minor improvements * temporarily prevent refetch * revert prefetch change * Update 2023-02-23.md * performance + a11y improvements * remove Lora font family --------- Co-authored-by: Andrico <andrico.karoulla@healthhero.com> Co-authored-by: Greg Whitworth <865244+gregwhitworth@users.noreply.github.com> Co-authored-by: Jhey Tompkins <jh3y@users.noreply.github.com> Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com> Co-authored-by: Martin <6279703+deleonio@users.noreply.github.com> Co-authored-by: Andrico <andrico@animaapp.com> Co-authored-by: Tantek Çelik <blog@tantek.com>
gregwhitworth
added a commit
to openui/open-ui
that referenced
this pull request
Feb 28, 2023
* [Site rewrite] Migrate site to astro (#606) * initial astro commit * minor config change * move over sources * fix prettier formatting * rename files and create layout * move to markdown * migrate markdown file * get navigation working * fix routing for pages * update the documentation * more fixes to styling * get layouts working for all pages * improve styles even more * get build working * fix image * fix navigation order * get navigation working * add favicon * fix page title * fix menu sorting * fix lighthouse issues * update node version * minors to styles * override gatsby build config * typo * fix navigation styles * remove unused dependencies, remove render blocking resources, prefetch resources * reduce font flashing, fix markup issues * fix build from breaking * test removing prefetch * rmeove compression * revert changes to config * fix prefetch * fix image paths * Create 2022-12-01.md * Update 2022-12-01.md * Update 2022-12-01.md * Update popup.research.explainer.mdx (#644) Remove lingering mention of `popover=hint` for now. * Popover target attribute updates (#647) The `popovertoggletarget`, `popovershowtarget` and `popoverhidetarget` attributes will initially map to `aria-expanded`. This has already been implemented in Chromium browsers. HTML AAM PR to add this mapping to the spec: w3c/html-aam#446 * Create 2023-01-05.md * Update 2023-01-05.md * Create 2023-01-12.md * docs: add kolibri accessible component lib (#624) * Update 2023-01-12.md * Create 2023-01-19.md * Task: Add redirect for popup (#653) * add redirect for popup * refactor code * let yarn do its thing * revert formatting change * add redirect comment Co-authored-by: Andrico <andrico@animaapp.com> * Update popover.research.explainer.mdx (#654) * Update popover.research.explainer.mdx * Update research/src/pages/popup/popover.research.explainer.mdx Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com> Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com> * Create 2023-02-02.md * fix layout issue * fix interactions * Update 2023-02-02.md * Update 2023-02-02.md * selectmenu is an element, code escape it (#660) * update layout and remove stale content * handle missing images * minor fixes and redirects * fix dead links * Create 2023-02-16.md * Update 2023-02-16.md * Adjusted the home page to reflect the current reality and ensure the relationship between Open UI & the W3C is clear (#663) * Create 2023-02-23.md * minor improvements * temporarily prevent refetch * revert prefetch change * Update 2023-02-23.md * performance + a11y improvements * remove Lora font family --------- Co-authored-by: Andrico <andrico.karoulla@healthhero.com> Co-authored-by: Greg Whitworth <865244+gregwhitworth@users.noreply.github.com> Co-authored-by: Jhey Tompkins <jh3y@users.noreply.github.com> Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com> Co-authored-by: Martin <6279703+deleonio@users.noreply.github.com> Co-authored-by: Andrico <andrico@animaapp.com> Co-authored-by: Tantek Çelik <blog@tantek.com> * remove unused dependencies --------- Co-authored-by: Andrico <karoulla.andrico@gmail.com> Co-authored-by: Andrico <andrico.karoulla@healthhero.com> Co-authored-by: Jhey Tompkins <jh3y@users.noreply.github.com> Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com> Co-authored-by: Martin <6279703+deleonio@users.noreply.github.com> Co-authored-by: Andrico <andrico@animaapp.com> Co-authored-by: Tantek Çelik <blog@tantek.com>
|
whatwg/html#8962 resolves the issue I mentioned earlier so that will require some changes here. One thing that seems somewhat awkward here is that certain requirements of HTML are restated. Ideally we'd build upon the model that HTML establishes so we don't have to make requirements as to when certain buttons are ignored for instance. |
|
thanks for the heads up @annevk. i'll review the changes and make updates. also agree, i can cut out requirements that are already defined in HTML. I was working on this in tandem with the original PR for the attributes, so this can be revised to remove redundancies. |
annevk
added a commit
to whatwg/html
that referenced
this pull request
Mar 8, 2023
Instead of popoverhidetarget, popovershowtarget, and popovertoggletarget, we will now have popovertarget and popovertargetaction. The former for targeting an element and the latter for determining what to do with the target. This also corrects popover validity checks in activation behavior and consistifies the popover attribute. Tests: web-platform-tests/wpt#38701. HTML-AAM: w3c/html-aam#446. Fixes #8894, fixes #8983, and fixes #8979.
scottaohara
added a commit
that referenced
this pull request
May 9, 2023
this commit supersedes #446 TODO: finalize `popover` attribute mappings
|
closing this per new PR #481 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://open-ui.org/components/popup.research.explainer and https://github.com/w3c/html-aam/wiki/HTML-Popover-Attribute-A11y-Proposal-(manual-and-auto)
Adds the following proposed attributes:
popoverpopoverhidetargetpopovershowtargetpopovertoggletargetPreview | Diff