Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wandb unwatch method belongs to experiment, not logger #1246

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Wandb unwatch method belongs to experiment, not logger #1246

merged 1 commit into from
Aug 9, 2023

Conversation

Seanny123
Copy link
Contributor

Description

Fixes #994

Changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

samet-akcay
samet-akcay approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this!

@samet-akcay samet-akcay merged commit 159f65c into openvinotoolkit:main Aug 9, 2023
5 of 6 checks passed
samet-akcay added a commit that referenced this pull request Aug 10, 2023
@samet-akcay @ashwinvaidya17
@djdameln @blaz-r @Seanny123
Merge main to feature/benchmarking (#1258)
6a8099d 
* Configure readthedocs via `.readthedocs.yaml` file (#1229)

* 🚚 Refactor Benchmarking Script (#1216)

* New printing stuff

* Remove dead code + address codacy issues

* Refactor try/except + log to comet/wandb during runs

* pre-commit error

* third-party configuration

---------

Co-authored-by: Ashwin Vaidya <ashwinitinvaidya@gmail.com>

* Update CODEOWNERS

* Enable training with only normal images for MVTec (#1241)

* ignore mask check when dataset has only normal samples

* update changelog

* Revert "🚚 Refactor Benchmarking Script" (#1239)

Revert "🚚 Refactor Benchmarking Script (#1216)"

This reverts commit 784767f.

* Update benchmarking notebook (#1242)

* Fix metadata path

* Update benchmarking notebook

* Fix links to model architecture images (#1245)

* Fix links to architecture images

* Change links to raw files

* Wandb unwatch method belongs to experiment, not logger (#1246)

unwatch method belongs to experiment, not logger

---------

Co-authored-by: Ashwin Vaidya <ashwin.vaidya@intel.com>
Co-authored-by: Ashwin Vaidya <ashwinitinvaidya@gmail.com>
Co-authored-by: Dick Ameln <dick.ameln@intel.com>
Co-authored-by: Blaž Rolih <61357777+blaz-r@users.noreply.github.com>
Co-authored-by: Sean Aubin <seanaubin@gmail.com>
samet-akcay added a commit that referenced this pull request Aug 15, 2023
@samet-akcay @ashwinvaidya17
@djdameln @blaz-r @Seanny123 @JoaoGuibs
Merge main into feature/pimo (#1273)
f62fde0 
* Configure readthedocs via `.readthedocs.yaml` file (#1229)

* 🚚 Refactor Benchmarking Script (#1216)

* New printing stuff

* Remove dead code + address codacy issues

* Refactor try/except + log to comet/wandb during runs

* pre-commit error

* third-party configuration

---------

Co-authored-by: Ashwin Vaidya <ashwinitinvaidya@gmail.com>

* Update CODEOWNERS

* Enable training with only normal images for MVTec (#1241)

* ignore mask check when dataset has only normal samples

* update changelog

* Revert "🚚 Refactor Benchmarking Script" (#1239)

Revert "🚚 Refactor Benchmarking Script (#1216)"

This reverts commit 784767f.

* Update benchmarking notebook (#1242)

* Fix metadata path

* Update benchmarking notebook

* Fix links to model architecture images (#1245)

* Fix links to architecture images

* Change links to raw files

* Wandb unwatch method belongs to experiment, not logger (#1246)

unwatch method belongs to experiment, not logger

* (Minor change) Added the tracer_kwargs to the TorchFXFeatureExtractor class (#1214)

* Added tracer_kwargs to torchfx

* Added tracer_kwargs on docstring

* Replace cdist in Patchcore (#1267)

* Ignore hidden directories when creating `Folder` dataset (#1268)

* Remove `config` from argparse in OpenVINO inference script. (#1257)

* Fix metadata path

* Remove leftover argument

* Update openvino entrypoint script

* Fix EfficientAD number of steps for optimizer lr change? (#1266)

* Fix metadata path

* Fix number of steps

---------

Co-authored-by: Ashwin Vaidya <ashwin.vaidya@intel.com>
Co-authored-by: Ashwin Vaidya <ashwinitinvaidya@gmail.com>
Co-authored-by: Dick Ameln <dick.ameln@intel.com>
Co-authored-by: Blaž Rolih <61357777+blaz-r@users.noreply.github.com>
Co-authored-by: Sean Aubin <seanaubin@gmail.com>
Co-authored-by: JoaoGuibs <32060480+JoaoGuibs@users.noreply.github.com>
@ashwinvaidya17 ashwinvaidya17 mentioned this pull request Aug 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samet-akcay samet-akcay samet-akcay approved these changes

@ashwinvaidya17 ashwinvaidya17 Awaiting requested review from ashwinvaidya17 ashwinvaidya17 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: AttributeError: 'AnomalibWandbLogger' object has no attribute 'unwatch'.
2 participants
@Seanny123 @samet-akcay