Replace cdist in Patchcore #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samet-akcay
approved these changes
Aug 14, 2023
samet-akcay
added a commit
that referenced
this pull request
Aug 15, 2023
* Configure readthedocs via `.readthedocs.yaml` file (#1229) * 🚚 Refactor Benchmarking Script (#1216) * New printing stuff * Remove dead code + address codacy issues * Refactor try/except + log to comet/wandb during runs * pre-commit error * third-party configuration --------- Co-authored-by: Ashwin Vaidya <ashwinitinvaidya@gmail.com> * Update CODEOWNERS * Enable training with only normal images for MVTec (#1241) * ignore mask check when dataset has only normal samples * update changelog * Revert "🚚 Refactor Benchmarking Script" (#1239) Revert "🚚 Refactor Benchmarking Script (#1216)" This reverts commit 784767f. * Update benchmarking notebook (#1242) * Fix metadata path * Update benchmarking notebook * Fix links to model architecture images (#1245) * Fix links to architecture images * Change links to raw files * Wandb unwatch method belongs to experiment, not logger (#1246) unwatch method belongs to experiment, not logger * (Minor change) Added the tracer_kwargs to the TorchFXFeatureExtractor class (#1214) * Added tracer_kwargs to torchfx * Added tracer_kwargs on docstring * Replace cdist in Patchcore (#1267) * Ignore hidden directories when creating `Folder` dataset (#1268) * Remove `config` from argparse in OpenVINO inference script. (#1257) * Fix metadata path * Remove leftover argument * Update openvino entrypoint script * Fix EfficientAD number of steps for optimizer lr change? (#1266) * Fix metadata path * Fix number of steps --------- Co-authored-by: Ashwin Vaidya <ashwin.vaidya@intel.com> Co-authored-by: Ashwin Vaidya <ashwinitinvaidya@gmail.com> Co-authored-by: Dick Ameln <dick.ameln@intel.com> Co-authored-by: Blaž Rolih <61357777+blaz-r@users.noreply.github.com> Co-authored-by: Sean Aubin <seanaubin@gmail.com> Co-authored-by: JoaoGuibs <32060480+JoaoGuibs@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces torch cdist that causes errors when it's exported to Onnx and OpenVINO. Performance stays the same, as new functions matches cdist in precision up to 10e-7, with small difference occurring due to numerical instability.
Changes
Checklist