Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto annotation GPU support #2546

Merged
merged 13 commits into from
Dec 15, 2020
Merged

Auto annotation GPU support #2546

merged 13 commits into from
Dec 15, 2020

Conversation

jahaniam
Copy link
Contributor

@jahaniam jahaniam commented Dec 9, 2020

Motivation and context

How has this been tested?

by checking docker logs and docker exec into the container and making sure nvidia-smi works and code runs on the GPU.

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@coveralls
Copy link

coveralls commented Dec 9, 2020

Coverage Status

Coverage increased (+0.3%) to 62.131% when pulling 18c18dd on jahaniam:develop into 76ff7ef on openvinotoolkit:develop.

@azhavoro
Copy link
Contributor

@jahaniam Thank you for the contribution, I'll test PR today.

Co-authored-by: Andrey Zhavoronkov <andrey.zhavoronkov@intel.com>
@jahaniam
Copy link
Contributor Author

@jahaniam Thank you for the contribution, I'll test PR today.

Looking forward to more collaborations.

I will slowly add the GPU support for other models as well. Next in line is MaskRCNN or adding support for detection2 framework(by facebook).

@nmanovic
Copy link
Contributor

@jahaniam , awesome contribution. I will look at the PR as well. Give us sometime. Really want to add your changes before our next release.

@jahaniam
Copy link
Contributor Author

@nmanovic I searched a lot but I couldn't find the exact place where the response of the nuclio functions are getting processed. For example, for this fast-rcnn, we send an image to the nuclio function and we get the labels and bounding box (rectangle type with points) as a response. But where this information is being processed in cvat? I appreciate if you can pinpoint me to line of the code that is processing the response from nuclio (or sending the request to nuclio). This will help me a lot in bug fixing and further contributing to the CVAT.
I could track it to the cvat rest API but no luck. Thank you.

@nmanovic
Copy link
Contributor

@nmanovic I searched a lot but I couldn't find the exact place where the response of the nuclio functions are getting processed. For example, for this fast-rcnn, we send an image to the nuclio function and we get the labels and bounding box (rectangle type with points) as a response. But where this information is being processed in cvat? I appreciate if you can pinpoint me to line of the code that is processing the response from nuclio (or sending the request to nuclio). This will help me a lot in bug fixing and further contributing to the CVAT.
I could track it to the cvat rest API but no luck. Thank you.

https://github.com/openvinotoolkit/cvat/tree/develop/cvat/apps/lambda_manager

@jahaniam
Copy link
Contributor Author

All comments have been addressed accordingly. I appreciate it if you can review it again. @nmanovic @azhavoro

@nmanovic
Copy link
Contributor

@jahaniam , great contribution! Thank you very much for you time. 👍

@nmanovic nmanovic merged commit 8343dd7 into cvat-ai:develop Dec 15, 2020
@jahaniam
Copy link
Contributor Author

@jahaniam , great contribution! Thank you very much for you time.

Thank you for open-sourcing this awesome software and being so responsive.

@jahaniam
Copy link
Contributor Author

Can you reopen the pr please?
sorry, I forgot to update the changelogs. I have updated that in my forked repo. Should I do another pr for that?

@jahaniam
Copy link
Contributor Author

@nmanovic

@jahaniam jahaniam mentioned this pull request Dec 15, 2020
8 tasks
@jahaniam jahaniam mentioned this pull request Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants