-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Large files uploads #3692
Large files uploads #3692
Conversation
@klakhov , I see that you have fixed only uploading data for tasks. I'm fine if you want to split the PR on several parts and implement huge file upload for other endpoints later. |
@klakhov ,
What do you think? |
@nmanovic |
@nmanovic Could you please take a look on updated pr. I've removed |
@klakhov , could you please resolve conflicts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
Comments for the future:
- I saw that in case of bulk upload we have the following operation for each file in python code: open, read, write, close. Probably we can just move them from a temporary location to upload directory. Probably it will be an optimization in the future.
- Need to update CLI to support the new protocol
- Need to add the protocol for all other upload operations (import task, import dataset, import project).
Motivation and context
Resolved #956
Resolved #2332
Resolved #1616
Fixed large files uploading via webpage, implemented using chunk file uploads with upload progress bar.
How has this been tested?
Manually tested with large videos, archives, 20k images
Checklist
develop
branchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.