Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with python 3.8 #134

Closed
bognabylicka opened this issue Sep 10, 2020 · 3 comments · Fixed by #206
Closed

Incompatibility with python 3.8 #134

bognabylicka opened this issue Sep 10, 2020 · 3 comments · Fixed by #206

Comments

@bognabylicka
Copy link

bognabylicka commented Sep 10, 2020

I noticed incompatibility of NNCF with python 3.8.
The problem occurs during installation of one of the dependencies of NNCF and it seems to be caused by the fact that platform.linux_distribution was removed in Python 3.8:

  ​Downloading matplotlib-3.0.3.tar.gz (36.6 B)
    ​ERROR: Command errored out with exit status :
     ​command: /opt/home/k8sworker/cibuilds/impt/nncf_for_digits-9/src/model_templates/.venv/bin/python3 -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-0zqb86kn/matplotlib/setup.py'"'"'; __file__='"'"'/tmp/pip-install-0zqb86kn/matplotlib/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-install-0zqb86kn/matplotlib/pip-egg-info
        ​cwd: /tmp/pip-install-0zqb86kn/matplotlb/
    ​Complete output (51 line):
    ​Traceback (most recent call last)
      ​File "<string>", line 1, in <module
      ​File "/tmp/pip-install-0zqb86kn/matplotlib/setup.py", line 225, in <module>
       ​msg = pkg.install_help_msg(
      ​File "/tmp/pip-install-0zqb86kn/matplotlib/setupext.py", line 650, in install_help_msg
       ​release = platform.linux_distribution()[0].lowe()
    ​AttributeError: module 'platform' has no attribute 'linux_distributin'```
@AlexKoff88
Copy link
Contributor

@asenina, can you please take a look and fix it when you are free from the current task?

@asenina
Copy link
Contributor

asenina commented Sep 17, 2020

@AlexKoff88 Ok

@jpowie01
Copy link

What's the status of this issue? It looks that NNCF uses too old version of Matplotlib (3.0.3).

Matplotlib supports Python 3.8 starting with version 2.2.5: https://github.com/matplotlib/matplotlib/releases/tag/v2.2.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants