Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread-safety #15

Closed
solardiz opened this issue Jan 10, 2023 · 1 comment · Fixed by #16
Closed

Thread-safety #15

solardiz opened this issue Jan 10, 2023 · 1 comment · Fixed by #16
Labels
enhancement New feature or request

Comments

@solardiz
Copy link
Member

Make -DENABLE_SETFSUGID the default and only implementation, and use the setgroups() direct syscall, so that we don't affect other threads' effective credentials.

As discussed in #14 (comment) @ldv-alt sees "no potential benefits in keeping the non-ENABLE_SETFSUGID variant, and it definitely makes sense to use the setgroups() syscall instead of the glibc function."

@solardiz solardiz added the enhancement New feature or request label Jan 10, 2023
@ldv-alt
Copy link
Collaborator

ldv-alt commented Jan 21, 2023

There is a complication associated with using syscall() instead of setgroups():
As long as fakeroot doesn't wrap syscall(), libnss_tcb wouldn't work under fakeroot.
I'll have a look what could be done on the fakeroot side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants