Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: restore rsa type in JWK #137

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

lukasjhan
Copy link
Contributor

I added the missing part(rsa) in JWK type

Signed-off-by: Lukas.J.Han <lukas.j.han@gmail.com>
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.44%. Comparing base (34b24c0) to head (1cc29ed).

Additional details and impacted files
@@            Coverage Diff             @@
##             next     #137      +/-   ##
==========================================
+ Coverage   97.43%   97.44%   +0.01%     
==========================================
  Files          23       23              
  Lines        1907     1915       +8     
  Branches      279      279              
==========================================
+ Hits         1858     1866       +8     
  Misses         49       49              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cre8
Copy link
Contributor

cre8 commented Mar 6, 2024

I don't think that's correct. The values for RSA have to be on the same level as the others, don't they?

@lukasjhan
Copy link
Contributor Author

I don't think that's correct. The values for RSA have to be on the same level as the others, don't they?

But this is the implementation from typescript.
https://github.com/microsoft/TypeScript/blob/main/src/lib/dom.generated.d.ts#L689
https://github.com/microsoft/TypeScript/blob/main/src/lib/dom.generated.d.ts#L1719

@cre8
Copy link
Contributor

cre8 commented Mar 6, 2024

I don't think that's correct. The values for RSA have to be on the same level as the others, don't they?

But this is the implementation from typescript.
https://github.com/microsoft/TypeScript/blob/main/src/lib/dom.generated.d.ts#L689
https://github.com/microsoft/TypeScript/blob/main/src/lib/dom.generated.d.ts#L1719

You are correct, I looked at another spec. From this point of view the change is fine!

@cre8 cre8 merged commit f02d6b0 into openwallet-foundation:next Mar 6, 2024
10 checks passed
cre8 pushed a commit to cre8/sd-jwt-js that referenced this pull request Mar 8, 2024
Signed-off-by: Lukas.J.Han <lukas.j.han@gmail.com>
Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
cre8 pushed a commit that referenced this pull request Mar 8, 2024
Signed-off-by: Lukas.J.Han <lukas.j.han@gmail.com>
Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants