feat(indy-vdr): did:sov resolver #1247

genaris · 2023-01-27T01:27:07Z

Following the strategy of 'small PRs', this one adds to indy-vdr package a DID Resolver for did:sov method. It offers the same features as the one based on indy-sdk.

The one for did:indy will be added in a further PR.

Signed-off-by: vickysomtee <victor@animo.id>

Work Funded by the Government of Ontario Signed-off-by: vickysomtee <victor@animo.id>

Signed-off-by: Timo Glastra <timo@animo.id>

Work Funded by the Government of Ontario Signed-off-by: vickysomtee <victor@animo.id>

Signed-off-by: Karim Stekelenburg <karim@animo.id>

Signed-off-by: vickysomtee <victor@animo.id>

Work funded by the Ontario Government Signed-off-by: vickysomtee <victor@animo.id>

Signed-off-by: vickysomtee <victor@animo.id>

Signed-off-by: Ariel Gentile <gentilester@gmail.com>

codecov-commenter · 2023-01-27T01:56:40Z

Codecov Report

Merging #1247 (b970c90) into main (b6ae948) will decrease coverage by 0.30%.
The diff coverage is 77.07%.

@@            Coverage Diff             @@
##             main    #1247      +/-   ##
==========================================
- Coverage   87.64%   87.35%   -0.30%     
==========================================
  Files         739      760      +21     
  Lines       17619    18149     +530     
  Branches     2992     3081      +89     
==========================================
+ Hits        15443    15854     +411     
- Misses       2169     2288     +119     
  Partials        7        7

Impacted Files	Coverage Δ
packages/indy-vdr/src/error/IndyVdrError.ts	`50.00% <50.00%> (ø)`
...es/indy-vdr/src/error/IndyVdrNotConfiguredError.ts	`50.00% <50.00%> (ø)`
packages/indy-vdr/src/error/IndyVdrNotFound.ts	`50.00% <50.00%> (ø)`
...s/src/formats/LegacyIndyCredentialFormatService.ts	`64.73% <64.73%> (ø)`
packages/indy-vdr/src/pool/IndyVdrPoolService.ts	`74.69% <74.69%> (ø)`
packages/indy-vdr/src/index.ts	`75.00% <75.00%> (ø)`
packages/anoncreds/src/utils/credential.ts	`76.81% <76.81%> (ø)`
packages/indy-vdr/src/pool/IndyVdrPool.ts	`85.96% <85.96%> (ø)`
packages/indy-vdr/src/utils/promises.ts	`88.88% <88.88%> (ø)`
...ackages/indy-vdr/src/dids/IndyVdrSovDidResolver.ts	`92.10% <92.10%> (ø)`
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Ariel Gentile <gentilester@gmail.com>

TimoGlastra

Some comments, but overall looks good. Nice!

packages/indy-vdr/src/dids/IndyVdrSovDidResolver.ts

packages/indy-vdr/src/dids/__tests__/IndyVdrSovDidResolver.test.ts

TimoGlastra · 2023-01-27T13:05:13Z

packages/indy-vdr/src/index.ts

+export * from './dids'
+export * from './error'
+export * from './pool'


Do we want to export all these services / methods? I want to be more careful going forward in what we see as public api. I think seeing the specific things built on top of the pool service (so anoncreds registry, did resolver, did registrar) as public api means we can more easily make non breaking changes.

What do you think?

Yes, maybe it's better to be more selective from the beginning.

For the moment I only picked the IndyDidSovResolver, which is the only class (among the existing ones) I think it will be used externally once an IndyVdrModule or so is created.

packages/indy-vdr/src/pool/IndyVdrPoolService.ts

Signed-off-by: Ariel Gentile <gentilester@gmail.com>

genaris · 2023-01-27T18:18:26Z

Some comments, but overall looks good. Nice!

Thanks! I think I covered all the feedback. Some other changes to be added in a further PR.

I noticed it's becoming a bit harder to make CI pass: I had to increase the timeout for some tests (create DID with endpoints and resolve takes ~30 secs) and also I've seen some OutOfMemory/Garbage Collector problems like:

FATAL ERROR: Reached heap limit Allocation failed - JavaScript heap out of memory
 1: 0xb6b850 node::Abort() [/opt/hostedtoolcache/node/18.13.0/x64/bin/node]
 2: 0xa806a6  [/opt/hostedtoolcache/node/18.13.0/x64/bin/node]
 3: 0xd52140 v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [/opt/hostedtoolcache/node/18.13.0/x64/bin/node]
 4: 0xd524e7 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [/opt/hostedtoolcache/node/18.13.0/x64/bin/node]
 5: 0xf2fbe5  [/opt/hostedtoolcache/node/18.13.0/x64/bin/node]
 6: 0xf420cd v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [/opt/hostedtoolcache/node/18.13.0/x64/bin/node]

Not sure if this could be related to the issue found in Askar. If it continues, maybe we can test with a patched ref-napi version to see how it performs.

Signed-off-by: Ariel Gentile <gentilester@gmail.com>

TimoGlastra · 2023-01-30T11:49:37Z

Some comments, but overall looks good. Nice!

Thanks! I think I covered all the feedback. Some other changes to be added in a further PR.

I noticed it's becoming a bit harder to make CI pass: I had to increase the timeout for some tests (create DID with endpoints and resolve takes ~30 secs) and also I've seen some OutOfMemory/Garbage Collector problems like:
FATAL ERROR: Reached heap limit Allocation failed - JavaScript heap out of memory
 1: 0xb6b850 node::Abort() [/opt/hostedtoolcache/node/18.13.0/x64/bin/node]
 2: 0xa806a6  [/opt/hostedtoolcache/node/18.13.0/x64/bin/node]
 3: 0xd52140 v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [/opt/hostedtoolcache/node/18.13.0/x64/bin/node]
 4: 0xd524e7 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [/opt/hostedtoolcache/node/18.13.0/x64/bin/node]
 5: 0xf2fbe5  [/opt/hostedtoolcache/node/18.13.0/x64/bin/node]
 6: 0xf420cd v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [/opt/hostedtoolcache/node/18.13.0/x64/bin/node]
Not sure if this could be related to the issue found in Askar. If it continues, maybe we can test with a patched ref-napi version to see how it performs.

Hmm but Node 18 should work fine right?

TimoGlastra · 2023-01-30T11:49:54Z

Is this ready to merge otherwise @genaris?

genaris · 2023-01-30T11:59:48Z

Is this ready to merge otherwise @genaris?

Yes, and if the issue with CI persists we can investigate it further to see where it is taking so much heap memory (and what's different from local node setup, as I haven't seen this particular issue locally).

Co-authored-by: Karim Stekelenburg <karim@animo.id> Co-authored-by: Ariel Gentile <gentilester@gmail.com> Co-authored-by: Timo Glastra <timo@animo.id> Co-authored-by: Jim Ezesinachi <ezesinachijim@gmail.com> Co-authored-by: Ry Jones <ry@linux.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kim Ebert <kim@developmint.work> Co-authored-by: Grammatopoulos Athanasios Vasileios <GramThanos@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Victor Anene <62852943+Vickysomtee@users.noreply.github.com> Co-authored-by: Jim Ezesinachi <jim@animo.id> Co-authored-by: KolbyRKunz <KolbyKunz@yahoo.com> Co-authored-by: Berend Sliedrecht <61358536+blu3beri@users.noreply.github.com> Co-authored-by: Jason C. Leach <jason.leach@fullboar.ca> Co-authored-by: Martin Auer <martin.auer97@gmail.com> Co-authored-by: Niall Shaw <100220424+niall-shaw@users.noreply.github.com> Co-authored-by: Pritam Singh <43764373+Zzocker@users.noreply.github.com> Co-authored-by: Mo <10432473+morrieinmaas@users.noreply.github.com> Co-authored-by: NB-MikeRichardson <93971245+NB-MikeRichardson@users.noreply.github.com> Co-authored-by: Amit-Padmani <106090107+Amit-Padmani@users.noreply.github.com> Co-authored-by: DaevMithran <61043607+DaevMithran@users.noreply.github.com> Co-authored-by: Alexander Shenshin <93187809+AlexanderShenshin@users.noreply.github.com> fix(openid4vc-client): set package to private (#1210) fix: fix typing issues with typescript 4.9 (#1214) Fixes #1205 resolver (#1247) fix: set updateAt on records when updating a record (#1272) fix(transport)!: added docs moved connection to connectionId (#1222) fix(indy-vdr): export relevant packages from root (#1291) fix(askar): generate nonce suitable for anoncreds (#1295) resolver and registrar for did:indy (#1253) fix: imports from core (#1303) fix: thread id improvements (#1311) fix: loosen base64 validation (#1312) fix(samples): dummy module response message type (#1321) fix: seed and private key validation and return type in registrars (#1324) fix!: don't emit legacy did:sov prefix for new protocols (#1245) fix(askar): anoncrypt messages unpacking (#1332) fix: expose indy pool configs and action menu messages (#1333) fix: create new socket if socket state is 'closing' (#1337) fix(anoncreds): include prover_did for legacy indy (#1342) fix(indy-sdk): import from core (#1346) fix(anoncreds-rs): save revocation registry index (#1351) fix: isNewSocket logic (#1355) fix(tenant): Correctly configure storage for multi tenant agents (#1359) Fixes hyperledger#1353 fix(anoncreds): Buffer not imported from core (#1367) fix(core): repository event when calling deleteById (#1356) fix(askar): custom error handling (#1372) fix: return HTTP 415 if unsupported content type (#1313) fix: remove named capture groups (#1378) fix example usage of indy-sdk-react-native package (#1382) fix: connection id in sessions for new connections (#1383) fix: did cache key not being set correctly (#1394) fix: incorrect type for anoncreds registration (#1396) fix: reference to indyLedgers in IndyXXXNotConfiguredError (#1397) fix: add reflect-metadata (#1409) fix: various anoncreds revocation fixes (#1416) fix: jsonld credential format identifier version (#1412) fix: remove `deleteOnFinish` and added documentation (#1418) fix(askar): default key derivation method (#1420) fix(anoncreds): make revocation status list inline with the spec (#1421) fix(anoncreds-rs): revocation status list as JSON (#1422) fix: issuance with unqualified identifiers (#1431) fix(connections): store imageUrl when using DIDExchange (#1433) fix(indy-vdr): do not force indy-vdr version (#1434) fix: small issues with migration and WAL files (#1443) fix: migration of link secret (#1444) fix: Emit RoutingCreated event for mediator routing record (#1445) fix: small updates to cheqd module and demo (#1439) fix: remove scope check from response (#1450)

vickysomtee and others added 23 commits November 24, 2022 15:24

Created the indy-vdr package

213187f

Signed-off-by: vickysomtee <victor@animo.id>

feat: create IndyVdrPool

6998abe

Signed-off-by: vickysomtee <victor@animo.id>

feat: create IndyVdrPool

a7f05ca

Signed-off-by: vickysomtee <victor@animo.id>

removed e-2-e test

f2e2455

Signed-off-by: vickysomtee <victor@animo.id>

feat: create IndyVdrPool Service

552d3a3

Signed-off-by: vickysomtee <victor@animo.id>

feat: created the IndyVdrNotFoundError

3cb4259

Signed-off-by: vickysomtee <victor@animo.id>

refactor: IndyVdr package

8794d1e

Work Funded by the Government of Ontario Signed-off-by: vickysomtee <victor@animo.id>

test: add indy-vdr tests

c0f4764

Signed-off-by: Timo Glastra <timo@animo.id>

refactor: IndyVdr package

d11da2a

Work Funded by the Government of Ontario Signed-off-by: vickysomtee <victor@animo.id>

refactor: IndyVdr package

3854c35

Work Funded by the Government of Ontario Signed-off-by: vickysomtee <victor@animo.id>

test(indy-vdr): add basic tests

6ec514e

Signed-off-by: Karim Stekelenburg <karim@animo.id>

fix(indy-vdr): fix import

8ff1dc9

Signed-off-by: Karim Stekelenburg <karim@animo.id>

test(indy-vdr): start credential definition

798406c

Signed-off-by: vickysomtee <victor@animo.id>

feat: created IndyNotCOnfiguredError

b51d60a

Work funded by the Ontario Government Signed-off-by: vickysomtee <victor@animo.id>

test(IndyVdr): schema && credential definition

139eacf

Work funded by the Ontario Government Signed-off-by: vickysomtee <victor@animo.id>

merge main

3004279

Signed-off-by: vickysomtee <victor@animo.id>

feat: IndyVdr Package

62b7ae3

Signed-off-by: vickysomtee <victor@animo.id>

import initial sov resolver

e113e1e

Signed-off-by: Ariel Gentile <gentilester@gmail.com>

test: add tests for SOV resolver

06c58c5

Signed-off-by: Ariel Gentile <gentilester@gmail.com>

Merge branch 'main' into feat/indy-vdr-resolver

dc04650

fix: did resolution result

1958381

Signed-off-by: Ariel Gentile <gentilester@gmail.com>

remove unused file

d415b40

Signed-off-by: Ariel Gentile <gentilester@gmail.com>

export types

ec6230a

Signed-off-by: Ariel Gentile <gentilester@gmail.com>

genaris requested a review from a team as a code owner January 27, 2023 01:27

genaris added 2 commits January 26, 2023 23:29

test: fix pool mock and increase timeout

db0963e

Signed-off-by: Ariel Gentile <gentilester@gmail.com>

test: increase timeout

f41e01d

Signed-off-by: Ariel Gentile <gentilester@gmail.com>

TimoGlastra approved these changes Jan 27, 2023

View reviewed changes

fix: resolve PR feedback

474b705

Signed-off-by: Ariel Gentile <gentilester@gmail.com>

genaris added 2 commits January 27, 2023 18:43

remove injectable decorator

9d10bd4

Signed-off-by: Ariel Gentile <gentilester@gmail.com>

Merge branch 'main' into feat/indy-vdr-resolver

b970c90

genaris merged commit b5eb08e into openwallet-foundation:main Jan 30, 2023

berendsliedrecht mentioned this pull request Feb 12, 2023

chore/remove file animo/aries-framework-javascript#25

Closed

genaris deleted the feat/indy-vdr-resolver branch February 19, 2023 20:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(indy-vdr): did:sov resolver #1247

feat(indy-vdr): did:sov resolver #1247

genaris commented Jan 27, 2023

codecov-commenter commented Jan 27, 2023 •

edited

TimoGlastra left a comment

TimoGlastra Jan 27, 2023

genaris Jan 27, 2023

genaris commented Jan 27, 2023

TimoGlastra commented Jan 30, 2023

TimoGlastra commented Jan 30, 2023

genaris commented Jan 30, 2023

feat(indy-vdr): did:sov resolver #1247

feat(indy-vdr): did:sov resolver #1247

Conversation

genaris commented Jan 27, 2023

codecov-commenter commented Jan 27, 2023 • edited

Codecov Report

TimoGlastra left a comment

Choose a reason for hiding this comment

TimoGlastra Jan 27, 2023

Choose a reason for hiding this comment

genaris Jan 27, 2023

Choose a reason for hiding this comment

genaris commented Jan 27, 2023

TimoGlastra commented Jan 30, 2023

TimoGlastra commented Jan 30, 2023

genaris commented Jan 30, 2023

codecov-commenter commented Jan 27, 2023 •

edited