fix: remove scope check from response #1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karim Stekelenburg <karim@animo.id>
Signed-off-by: Karim Stekelenburg <karim@animo.id>
Signed-off-by: Karim Stekelenburg <karim@animo.id>
Codecov Report
@@ Coverage Diff @@
## main #1450 +/- ##
==========================================
- Coverage 85.55% 80.17% -5.38%
==========================================
Files 886 856 -30
Lines 21156 20570 -586
Branches 3635 3546 -89
==========================================
- Hits 18099 16493 -1606
- Misses 2882 3793 +911
- Partials 175 284 +109
|
TimoGlastra
approved these changes
May 10, 2023
TimoGlastra
added a commit
that referenced
this pull request
May 16, 2023
Co-authored-by: Karim Stekelenburg <karim@animo.id> Co-authored-by: Ariel Gentile <gentilester@gmail.com> Co-authored-by: Timo Glastra <timo@animo.id> Co-authored-by: Jim Ezesinachi <ezesinachijim@gmail.com> Co-authored-by: Ry Jones <ry@linux.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kim Ebert <kim@developmint.work> Co-authored-by: Grammatopoulos Athanasios Vasileios <GramThanos@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Victor Anene <62852943+Vickysomtee@users.noreply.github.com> Co-authored-by: Jim Ezesinachi <jim@animo.id> Co-authored-by: KolbyRKunz <KolbyKunz@yahoo.com> Co-authored-by: Berend Sliedrecht <61358536+blu3beri@users.noreply.github.com> Co-authored-by: Jason C. Leach <jason.leach@fullboar.ca> Co-authored-by: Martin Auer <martin.auer97@gmail.com> Co-authored-by: Niall Shaw <100220424+niall-shaw@users.noreply.github.com> Co-authored-by: Pritam Singh <43764373+Zzocker@users.noreply.github.com> Co-authored-by: Mo <10432473+morrieinmaas@users.noreply.github.com> Co-authored-by: NB-MikeRichardson <93971245+NB-MikeRichardson@users.noreply.github.com> Co-authored-by: Amit-Padmani <106090107+Amit-Padmani@users.noreply.github.com> Co-authored-by: DaevMithran <61043607+DaevMithran@users.noreply.github.com> Co-authored-by: Alexander Shenshin <93187809+AlexanderShenshin@users.noreply.github.com> fix(openid4vc-client): set package to private (#1210) fix: fix typing issues with typescript 4.9 (#1214) Fixes #1205 resolver (#1247) fix: set updateAt on records when updating a record (#1272) fix(transport)!: added docs moved connection to connectionId (#1222) fix(indy-vdr): export relevant packages from root (#1291) fix(askar): generate nonce suitable for anoncreds (#1295) resolver and registrar for did:indy (#1253) fix: imports from core (#1303) fix: thread id improvements (#1311) fix: loosen base64 validation (#1312) fix(samples): dummy module response message type (#1321) fix: seed and private key validation and return type in registrars (#1324) fix!: don't emit legacy did:sov prefix for new protocols (#1245) fix(askar): anoncrypt messages unpacking (#1332) fix: expose indy pool configs and action menu messages (#1333) fix: create new socket if socket state is 'closing' (#1337) fix(anoncreds): include prover_did for legacy indy (#1342) fix(indy-sdk): import from core (#1346) fix(anoncreds-rs): save revocation registry index (#1351) fix: isNewSocket logic (#1355) fix(tenant): Correctly configure storage for multi tenant agents (#1359) Fixes hyperledger#1353 fix(anoncreds): Buffer not imported from core (#1367) fix(core): repository event when calling deleteById (#1356) fix(askar): custom error handling (#1372) fix: return HTTP 415 if unsupported content type (#1313) fix: remove named capture groups (#1378) fix example usage of indy-sdk-react-native package (#1382) fix: connection id in sessions for new connections (#1383) fix: did cache key not being set correctly (#1394) fix: incorrect type for anoncreds registration (#1396) fix: reference to indyLedgers in IndyXXXNotConfiguredError (#1397) fix: add reflect-metadata (#1409) fix: various anoncreds revocation fixes (#1416) fix: jsonld credential format identifier version (#1412) fix: remove `deleteOnFinish` and added documentation (#1418) fix(askar): default key derivation method (#1420) fix(anoncreds): make revocation status list inline with the spec (#1421) fix(anoncreds-rs): revocation status list as JSON (#1422) fix: issuance with unqualified identifiers (#1431) fix(connections): store imageUrl when using DIDExchange (#1433) fix(indy-vdr): do not force indy-vdr version (#1434) fix: small issues with migration and WAL files (#1443) fix: migration of link secret (#1444) fix: Emit RoutingCreated event for mediator routing record (#1445) fix: small updates to cheqd module and demo (#1439) fix: remove scope check from response (#1450)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the
requestCredentialmethod would throw an error if thescopeparameter was not present in theaccess_tokenresponse. Thisscopevalue was used to indicate the desired credential type when requesting the credential. However, this was incorrect, as this value is optional according to the specification.This PR removes the requirement for the
scopeto be present on theaccess_tokenresponse. If thescopeis present, it will be used to check if the server metadata indicates the requested credential format is supported for the requested credential type (indicated by thescope). If not, this validation is skipped.When the
access_tokenresponse does not contain ascope, thecredentialTypevalue that is passed to the underlying Sphereon library will be undefined. When this happens, the Sphereon library will use thecredentialTypevalue from the issuance initiation request instead (relevant code here), which should always be present according to the spec.@TimoGlastra, @blu3beri, could one of you please verify these changes are in line with the specs?
Related to #1322
Signed-off-by: Karim Stekelenburg karim@animo.id