Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove scope check from response #1450

Merged
merged 3 commits into from
May 10, 2023
Merged

fix: remove scope check from response #1450

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a4d47e9
fix: remove scope check from response
karimStekelenburg May 9, 2023
87e0703
fix: remove scope check from response
karimStekelenburg May 9, 2023
4ac5069
fix: remove unused options parameter
karimStekelenburg May 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions packages/openid4vc-client/src/OpenId4VcClientService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,12 +257,11 @@ export class OpenId4VcClientService {

this.logger.debug('Full server metadata', serverMetadata)

if (!accessToken.scope) {
throw new AriesFrameworkError(
"Access token response doesn't contain a scope. Only scoped issuer URIs are supported at this time."
)
if (accessToken.scope) {
for (const credentialType of accessToken.scope.split(' ')) {
this.assertCredentialHasFormat(credentialFormat, credentialType, serverMetadata)
}
}
this.assertCredentialHasFormat(credentialFormat, accessToken.scope, serverMetadata)

// proof of possession
const callbacks = this.getSignCallback(agentContext)
Expand Down