-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should A
stand for angstrom or ampere?
#743
Comments
If it doesn't break a bunch of things and isn't too hard to do, I'd be in favor of the change. The SI symbol for the ampere is A (it's one of the seven SI base units), and I agree that it is much more likely for end users to mean ampere than angstrom if they put in that symbol. That said, it's also not that hard to work around if changing the symbol would break things. |
I also think The only references to Angstroms in the OPL are help files:
The question is whether you want a gradual transition or you like the Big Bang approach. Either way, the first step is to add the new unit for Angstrom to Units.pm so that the help files in WW and OPL can be updated when the new unit is available in production. I've just opened PR #753 to add some new units. The new angstrom could be added to that PR for convenience or separated out in its own PR for faster merging to main. |
We've merged in some changes (listed above) to handle angstroms. |
In
Units.pm
, the unitA
is for angstrom, 10e-10 meters. Alsoamp
is one of the fundamental units.I searched the OPL (OPL, Contrib, and Pending folders) and I found no problems at all that use either of the above units. My grep regex in the search was
WithUnits(.*\W\(A\|amp\)\W
, which I think was sufficient but maybe is not. It found a few instances likeNumberWithUnits("$A","hr");
but nothing with theA
actually being used as a unit.Of course any such regex is not 100% conclusive, if the unit is hidden in a variable.
Anyway, it seems to me that
A
is much more commonly used as the abbreviation for ampere. (That is how it was being thought of recently when a student entered an answer of0 T m/A
and discovered a bug.)Should we change the meaning of
A
to ampere? It feels 1000x more likely to be used by a student to mean ampere than to mean angstrom. If there is ever a WW exercise that needs angstrom, well first of allA
is not even the right character for that. It should beÅ
. But second of all, that exercise with its context could be coded to override the meaning ofA
.The text was updated successfully, but these errors were encountered: