Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons in LB1 to signal problems with math objects and static problems #530

Merged
merged 7 commits into from
Jan 2, 2015

Conversation

jwj61
Copy link
Member

@jwj61 jwj61 commented Dec 28, 2014

There are new tags in OPL problems to signal if the problem uses math objects and if it is static. This change puts the information in the OPL database.

If a problem uses math objects, an icon appears next to the rerandomize icon to signal that (in Library Browser 1). The icon has hover text to explain what it is, and clicking on it opens a help pop-up to explain the significance of math objects to an instructor browsing problems.

If a problem is tagged as static, the rerandomize icon is simply not shown.

If a problem is not part of the OPL, (e.g., browsing problems in the templates directory), the problem is checked directly for the tags and acts accordingly. In all cases, the default action (i.e., if there are no special tags), is to not show the math object icon and to show the rerandomize icon.

using Math Objects, and the radomize icon is not shown if a problem
is tagged as being static.
…ays opens a short help message explaining what Math Objects are from an instructor's point of view.
@goehle
Copy link
Member

goehle commented Dec 31, 2014

Could you give me a subject/chapter/section of problems with each of the tags. I've run OPL-update and seen both mathobject and static problems, but no icons. I'm assuming only some are flagged.

@goehle
Copy link
Member

goehle commented Dec 31, 2014

Also, hitting rerandomize on problems with static images causes the images to dissapear. Is this new bug (e.g. Library/NAU/setCalcII/workAndForce.pg) ?

@goehle
Copy link
Member

goehle commented Jan 1, 2015

I tracked that bug down and fixed it in #531. I couldn't find any problems with the icons, though.

@jwj61
Copy link
Member Author

jwj61 commented Jan 1, 2015

The tagging for math objects and static problems should be pretty thorough. To see the MO icon, I start with Single variable Calc/Limits and Cont/Rules of limits - basic. Restricting to the first 5, of them have the icon.

For static problems, there should not be a randomize icon at all. If you can rerandomize a problem marked as static, then that is not showing.

Do you have the icon, it is htdocs/images/pibox.png .

@goehle
Copy link
Member

goehle commented Jan 1, 2015

I needed the latest OPL to get it to work. I have it going now. I will say that the pi icon would look better without the black border, at least in math4. None of the other icons have borders so it really stands out.

@jwj61
Copy link
Member Author

jwj61 commented Jan 1, 2015

The thinking was that pi is a symbol of math, and the border represents it being an object. Other suggestions people had for the icon were to use a tiny picture of Davide, or to have the 3-d pi spinning (to make it clear it was an object and not just a math symbol). Compared to those, the current icon is probably looking pretty good now.

<body><br>
<p>
Some WeBWorK are programmed using what are called <i>Math Objects</i>.
These problems are preferred by some people because they
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "Some WeBWorK problems"

@goehle
Copy link
Member

goehle commented Jan 1, 2015

I kind of like a 3d spinning gif of Davide's head. In any case, other questions comments. The prev/next thing really needs to be fixed. The other stuff is a bit more grey.

  • Lots of problems have the MathObjects icon but dont actually use math objects (/Library/WHFreeman/Rogawski_Calculus_Early_Transcendentals_Second_Edition/3_Differentiation/3.6_Trigonometric_Functions/3.6.37.pg) I think it may be because they load the MathObjects macro but dont actually do anything with it. Its a problem with tagging and not this pull, in any case.
  • For some MathObject problems I also get the blue MathObject message and for others I dont. (e.g. Library/Michigan/Chap8Sec5/Q23.pg) It seems like if we have the icon we also dont need the blue messages.
  • Clicking "Next Page" or "Previous Page" causes all problems to get MathObject icons.
  • Clicking "Next Page" and then "Previous Page" will cause problems which didn't have the randomize icon to have the randomize icon. I think this is a problem associated to the getDBextras stuff.
  • Clicking "M" and then hiding the top problem causes the L and the Pi icon to switch places (if the next problem has a pi, that is).

@jwj61
Copy link
Member Author

jwj61 commented Jan 1, 2015

Some of these can be addressed now. I will get to the others in time.

  • The missing word in the help file has been added (from earlier comment)
  • I hope erroneous MO tags are not in many files. As you say, this should be considered a bug in that individual problem. The bulk were done by a script which looked for "->cmp" (not loading mathobjects). People at OPL IV were then converting individual problems to math objects, and the one pointed out was poorly done.
  • The blue math object comments will be removed at some point in the future. If I remove those comments before this pull becomes a part of a webwork release, people may be unhappy.

On to the interaction with Next/Previous/M.

more like this M/L when removing the leader of a MLT group from view
when it is open.
@jwj61
Copy link
Member Author

jwj61 commented Jan 2, 2015

The problems with next/previous buttons and the more-like-this M/L should now be fixed.

my $tags = WeBWorK::Utils::Tags->new($path);
$tags->settag('DBsubject', $subj, 1);
$tags->settag('DBchapter', $chap, 1);
$tags->settag('DBsection', $sect, 1);
$tags->settag('Level', $level, 1);
$tags->settag('Status', $status, 0) if $status;
eval {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity what is the status tag?

@jwj61
Copy link
Member Author

jwj61 commented Jan 2, 2015

Oops. Harmless for now, but used in my next contribution which will be tools for OPL editors (so they can review contributions to the OPL through webwork). The status is whether the problem under review has been accepted/rejected/marked for further consideration.

goehle added a commit that referenced this pull request Jan 2, 2015
Icons in LB1 to signal problems with math objects and static problems

Sounds like a good project. 

The issues with Prev/Next and the icon orders were fixed.  Everything else checks out so I'll merge.
@goehle goehle merged commit 02a492b into openwebwork:develop Jan 2, 2015
@jwj61 jwj61 deleted the motags branch June 23, 2015 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants