-
-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icons in LB1 to signal problems with math objects and static problems #530
Conversation
… and is the problem static
using Math Objects, and the radomize icon is not shown if a problem is tagged as being static.
…ays opens a short help message explaining what Math Objects are from an instructor's point of view.
Could you give me a subject/chapter/section of problems with each of the tags. I've run OPL-update and seen both mathobject and static problems, but no icons. I'm assuming only some are flagged. |
Also, hitting rerandomize on problems with static images causes the images to dissapear. Is this new bug (e.g. Library/NAU/setCalcII/workAndForce.pg) ? |
I tracked that bug down and fixed it in #531. I couldn't find any problems with the icons, though. |
The tagging for math objects and static problems should be pretty thorough. To see the MO icon, I start with Single variable Calc/Limits and Cont/Rules of limits - basic. Restricting to the first 5, of them have the icon. For static problems, there should not be a randomize icon at all. If you can rerandomize a problem marked as static, then that is not showing. Do you have the icon, it is htdocs/images/pibox.png . |
I needed the latest OPL to get it to work. I have it going now. I will say that the pi icon would look better without the black border, at least in math4. None of the other icons have borders so it really stands out. |
The thinking was that pi is a symbol of math, and the border represents it being an object. Other suggestions people had for the icon were to use a tiny picture of Davide, or to have the 3-d pi spinning (to make it clear it was an object and not just a math symbol). Compared to those, the current icon is probably looking pretty good now. |
<body><br> | ||
<p> | ||
Some WeBWorK are programmed using what are called <i>Math Objects</i>. | ||
These problems are preferred by some people because they |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be "Some WeBWorK problems"
I kind of like a 3d spinning gif of Davide's head. In any case, other questions comments. The prev/next thing really needs to be fixed. The other stuff is a bit more grey.
|
Some of these can be addressed now. I will get to the others in time.
On to the interaction with Next/Previous/M. |
more like this M/L when removing the leader of a MLT group from view when it is open.
The problems with next/previous buttons and the more-like-this M/L should now be fixed. |
my $tags = WeBWorK::Utils::Tags->new($path); | ||
$tags->settag('DBsubject', $subj, 1); | ||
$tags->settag('DBchapter', $chap, 1); | ||
$tags->settag('DBsection', $sect, 1); | ||
$tags->settag('Level', $level, 1); | ||
$tags->settag('Status', $status, 0) if $status; | ||
eval { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity what is the status tag?
Oops. Harmless for now, but used in my next contribution which will be tools for OPL editors (so they can review contributions to the OPL through webwork). The status is whether the problem under review has been accepted/rejected/marked for further consideration. |
Icons in LB1 to signal problems with math objects and static problems Sounds like a good project. The issues with Prev/Next and the icon orders were fixed. Everything else checks out so I'll merge.
There are new tags in OPL problems to signal if the problem uses math objects and if it is static. This change puts the information in the OPL database.
If a problem uses math objects, an icon appears next to the rerandomize icon to signal that (in Library Browser 1). The icon has hover text to explain what it is, and clicking on it opens a help pop-up to explain the significance of math objects to an instructor browsing problems.
If a problem is tagged as static, the rerandomize icon is simply not shown.
If a problem is not part of the OPL, (e.g., browsing problems in the templates directory), the problem is checked directly for the tags and acts accordingly. In all cases, the default action (i.e., if there are no special tags), is to not show the math object icon and to show the rerandomize icon.