Develop rename update #642
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…develop_rename_update
In particular don't update in retitleCourse if the box is not checked even if there is an entry in the box. Still need to verify this when the course is actually renamed
Need to improve the report messages to say the previous values of title and institution
Next step will be to add information about previous values when the values are changed.
… as well as the new title and institution.
|
This is a pull from a branch off of develop into 2.11. In general this is bad, but because 2.11 got split off of develop after this branch, and since this branch hasn't had develop pulled back in recently, its probably OK. The better thing to do would be to rebase this branch to release-2.11 using |
|
replace with clean version from release-2.11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
version of rename update pull request being made to release-2.11. As far as I can tell this is clean and only changes the files that I changed to update the develop branch.
I didn't figure out how to use rebase to change my laptop version of release-2.11 to include the recent changes. I'll be happy for some hints about how to do that.