-
-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Even More 2.11 Bugfixes #661
Conversation
goehle
commented
Dec 14, 2015
- Fixed an issue where answers of 0 were not being preserved after timeout.
- To test set your timeout value to be low, enter a 0 for any problem answer, wait, and hit check answers. Before the patch after logging back in the submitted answer will be blank, after the patch it should have a zero.
- Made a better error when there is no set name when creating a set via the library browser.
- To test make a set via the library browser but don't input a set name.
- Fixed an issue with the success message when appending a problem via PGProblemEditor3
- To test append a problem with PGProblemEditor3.
- Fixed an issue with columns on the Problem Set page.
- To test, make a set with an essay answer. Check the formatting of Problem Set. Submit an answer and check the formatting of Problem Set with the grader link. Change the set type to Jitar and check the formatting again.
- Changed how essay answer comments were rendered on the Problem page. It should be faster and more generic. Test by assigning an essay answer, grading it with a comment, and checking that it renders on the problem page correctly.
- Added css to make problem set detail 2 work in math3.
- To test, change to math3 and visit the problem set detail 2 page. Everything should function, although it doesn't look quite as good.
… via the Library browser.
I did not see a change in behavior when no set name was defined in the Library Browser and a problem was added to the set. (Pop up message urges you to define a target set both before and after updating). I did not see a change in the columns for essay questions. They looked ok to me before and after the upgrade. What was the problem? |
Huh, I didn't get that popup, I wonder why. Well I improved the message If you look closely (or use the html inspector) before the change to the On Sat, Dec 19, 2015 at 7:55 PM, Michael Gage notifications@github.com
|
If I go to the library browser, choose subject, chapter and section and "view problems" and then I choose "add" for the first problem I get the following pop-up message: "You need to pick a target set above so we know what set to which we should add this problem." (The target set has not been chosen and no new set was created either.). I don't see additional messages about not having chosen a set. However if I push "create a new set for this course" without filling in the blank for the set name I get a message (in red) "You did not specify a new set name." This is an improvement over the old message "Problem creating set so I assume this is the message you are talking about. |
I see the mismatch between the header and the text in the "grade problem" column now. I just missed it before. This pull request is good to go. |
Yup, thats it. On Sun, Dec 20, 2015 at 9:29 AM, Michael Gage notifications@github.com
|