Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grade Totals and Other Tweaks #678

Merged
merged 16 commits into from Jan 30, 2016
Merged

Grade Totals and Other Tweaks #678

merged 16 commits into from Jan 30, 2016

Conversation

goehle
Copy link
Member

@goehle goehle commented Jan 18, 2016

This is mainly the grade totals feature asked for by BMCC, but there are a couple other small things.

  • The grades page should show percentages, in addition to total points correct, and it should have homework totals (and a percentage). The external scoring message display should be a little cleaner.
  • To test: View the grade table and make sure it looks ok.
  • To test: Create an email message with [tmpl]/email/report_grades.msg and a merge file [scoring]/report_grades_data.csv. (Just copy over a scoring tools csv.) Check that the resulting message works in the Grades page.
  • The email manager should remember the last email you had open, as well as any merge files you were looking at, between visits to the email page.
  • To test: Go to the email page, open a set and a merge file, leave the page and come back. Check that they are still open.
  • Made a small change to how xmlrpc errors are presented. Before the xmlrpc error was innocuous and hidden away at the begining of the error page. (It might have been a bug that it was there at all.) I made it so that it stands out more.
  • To test: Go to the library browser, then change the url of your server in site.conf to something nonsensical and restart the server. Now click on a subject in the opl and wait for the popup. Before the patch the "500 error" will be hard to see and after it will be obvious.
  • Fixed a bug with the Problem Grader. When students had a score not on the drop down it defaulted to 100.
  • To test: Set up a problem with two graded parts and one essay part (like the one below) and get the graded parts correct. Then go to the Problem Grader. The grade should be 70 and not 100.
```
DOCUMENT();      
loadMacros(
"PGstandard.pl", 
"MathObjects.pl",
"PGessaymacros.pl",
);
TEXT(beginproblem());
$showPartialCorrectAnswers = 1;
Context("Numeric");
$pi = Real("pi");
$pi2 = Real("pi");
Context()->texStrings;
BEGIN_TEXT
Enter a value for \(\pi\): \{$pi->ans_rule\} $PAR
Enter a value for \(\pi\): \{$pi2->ans_rule\} $PAR
Talk about yourself: $BR
\{essay_box()\}
END_TEXT
Context()->normalStrings;
ANS($pi->with(tolerance=>.0001)->cmp);
ANS($pi2->cmp);
ANS(essay_cmp());
ENDDOCUMENT();        
```
  • Added the "viewable_sections" code to ProblemGrader and cleaned up the modelCourse version of course.conf with examples of "viewable_sections". Right now "viewable_sections" limits what students a professor can see to a set collection of sections. It works on the Student Progress Page, the Problem Grader Page, the Email page, and a couple others. Notably it does not work on the Classlist Editor or the Users Assigned to Set page. If it turns out to be a useful feature it could be expanded. Notably this is not a new feature, its been around for a long time and I'm just making it a little more obvious.
  • To test: Check out the course.conf file and see that it looks ok.
  • To test: Add something like
```
$viewable_sections = { user_id1 => [1 ,2 ,3] ,
                     user_id2 => [1],
                                              };
```

to your course.conf file and check that the filtering works on Email, Student Progress, and the Problem Grader.  

@mgage
Copy link
Sponsor Member

mgage commented Jan 29, 2016

Grade table looks good. The style of presenting # of correct answers and per centages matches between the grades table and the show grades for one person page. They don't match the show grades for all people and one set page. (On this page there is no percentages and the number of correct answers has .xx decimal expansion only when the expansion is not 0. ) Not a big deal.

@mgage
Copy link
Sponsor Member

mgage commented Jan 30, 2016

Email merge works.

@mgage
Copy link
Sponsor Member

mgage commented Jan 30, 2016

Email remembers the last files used. The grader pop down menu registers correctly.
The xmlrpc error report is a pop over window that fills the screen.
The viewable sections restriction works as advertised. It also works on the "instructor tools" page.

@mgage
Copy link
Sponsor Member

mgage commented Jan 30, 2016

This is ready to pull.

mgage added a commit that referenced this pull request Jan 30, 2016
Grade Totals and Other Tweaks
@mgage mgage merged commit f882378 into openwebwork:develop Jan 30, 2016
@goehle goehle mentioned this pull request Apr 20, 2016
41 tasks
@goehle goehle deleted the gradetotals branch July 15, 2016 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants