Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repair soundcloud integration #614

Open
adrienjoly opened this issue Jun 2, 2023 · 4 comments
Open

repair soundcloud integration #614

adrienjoly opened this issue Jun 2, 2023 · 4 comments

Comments

@adrienjoly
Copy link
Member

I received this email from soundcloud, this morning:

Hello,We are reaching out today as you are the registered owner of a SoundCloud application that has been inactive for over 3 months. We’re writing to inform you that as of June 8, 2023, we are revoking access to your application in order to make necessary changes to our platform. As a result you will be unable to access SoundCloud’s API and any apps that use our APIs will no longer work.We understand that this may be disappointing; however, we need to do this for two reasons:Recently, we haven’t been able to provide developers with the level of support that you deserve. That includes being able to help you when things go wrong and supporting you when you build amazing things.More pressingly, we haven’t been able to sustain the level of oversight needed to make sure bad actors aren’t abusing our API. As such, change is necessary in order to protect the artists and fans that use SoundCloud’s services.Rest assured, this is not the final state of our API program - just a temporary reset. We’re working hard to reopen the doors as soon as possible so that you can use our API in the future.We’ll be releasing updates over the coming months, so please keep an eye on our Developer Blog and Twitter for updates to come.Amid these changes, we value your feedback. If you have notes or ideas for our developer platform, please feel free to leave comments on the form.

Hello,

We are reaching out today as you are the registered owner of a SoundCloud application that has been inactive for over 3 months. We’re writing to inform you that as of June 8, 2023, we are revoking access to your application in order to make necessary changes to our platform. As a result you will be unable to access SoundCloud’s API and any apps that use our APIs will no longer work.

We understand that this may be disappointing; however, we need to do this for two reasons:
  • Recently, we haven’t been able to provide developers with the level of support that you deserve. That includes being able to help you when things go wrong and supporting you when you build amazing things.
  • More pressingly, we haven’t been able to sustain the level of oversight needed to make sure bad actors aren’t abusing our API. As such, change is necessary in order to protect the artists and fans that use SoundCloud’s services.
Rest assured, this is not the final state of our API program - just a temporary reset. We’re working hard to reopen the doors as soon as possible so that you can use our API in the future.

We’ll be releasing updates over the coming months, so please keep an eye on our Developer Blog and Twitter for updates to come.

Amid these changes, we value your feedback. If you have notes or ideas for our developer platform, please feel free to leave comments on the form.
SOUNDCLOUD Hello,

We are reaching out today as you are the registered owner of a SoundCloud application that has been inactive for over 3 months. We’re writing to inform you that as of June 8, 2023, we are revoking access to your application in order to make necessary changes to our platform. As a result you will be unable to access SoundCloud’s API and any apps that use our APIs will no longer work.

We understand that this may be disappointing; however, we need to do this for two reasons:
Recently, we haven’t been able to provide developers with the level of support that you deserve. That includes being able to help you when things go wrong and supporting you when you build amazing things.
More pressingly, we haven’t been able to sustain the level of oversight needed to make sure bad actors aren’t abusing our API. As such, change is necessary in order to protect the artists and fans that use SoundCloud’s services.
Rest assured, this is not the final state of our API program - just a temporary reset. We’re working hard to reopen the doors as soon as possible so that you can use our API in the future.

We’ll be releasing updates over the coming months, so please keep an eye on our Developer Blog and Twitter for updates to come.

Amid these changes, we value your feedback. If you have notes or ideas for our developer platform, please feel free to leave comments on the form.

@adrienjoly adrienjoly added the bug label Jun 2, 2023
@adrienjoly
Copy link
Member Author

The soundcloud developer account associated to the recipient email address only has 1 application:

image

client id: 94f7290349b7801c04969260c4433fed

not mentioned in the code base => it may belong to adrienjoly/playemjs#59

@adrienjoly
Copy link
Member Author

Broken SoundCloud API may be the reason why we have many eId: "/sc/undefined" posts. Cf the following mongo query:

> db.post.find({eId:"/sc/undefined"}).sort({_id:-1}).limit(1)

{ "_id" : ObjectId("648d30757f358373aecb33d2"), "uId" : "648139e6d1b1033fa62c4294", "uNm" : "Zashit666", "text" : "", "name" : "Unleashing Vengeance - Epicus / explosive decompression", "eId" : "/sc/undefined", "ctx" : "bk", "src" : { "id" : "https://soundcloud.com/zamusic321", "name" : "Stream ZA Music music | Listen to songs, albums, playlists for free on SoundCloud" } }

adrienjoly added a commit that referenced this issue Sep 7, 2023
adrienjoly added a commit that referenced this issue Sep 7, 2023
Contributes to #718 and #614.

## What does this PR do / solve?

The top track listed on the [hot tracks page](https://openwhyd.org/hot) has an invalid SoundCloud `eId`, causing its score to artificially accumulate the stats of all posts with that same invalid `eId: "/sc/undefined"`.

```json
    {
      "_id": "53f5d7af7b4e770b172679bc",
      "uId": "52e2620f7e91c862b2b3f66a",
      "uNm": "Rien",
      "text": "",
      "pl": { "name": "Balkan Beat Gypsy #3", "id": 144 },
      "name": "Haris Pilton - Gypsy Partizans (2013)",
      "eId": "/sc/undefined",
      "img": "https://i1.sndcdn.com/artworks-000047093292-y6wbnv-large.jpg?e76cf77",
      "nbP": 958,
      "lov": [
        "53da584ce04b7b4fca7cf528",
        "518b5a447e91c862b2adea1a",
        "6485e598d1b1033fa650d66b"
      ],
      "nbR": 213,
      "score": 900,
      "nbL": 19,
      "prev": 900,
      "trackId": "54bf88e3e04b7b4fca82c18f",
      "rankIncr": 0,
      "trackUrl": "//soundcloud.com/undefined",
      "isLoved": false
    }
```

## Overview of changes

Until we fix the root cause (see #614), skip tracks with invalid soundcloud `eId`.
adrienjoly pushed a commit that referenced this issue Sep 7, 2023
## [1.55.65](v1.55.64...v1.55.65) (2023-09-07)

### Bug Fixes

* **hot-tracks:** don't include invalid SoundCloud `eId` ([#719](#719)) ([9b25e3d](9b25e3d)), closes [#718](#718) [#614](#614) [#3](#3) [#614](#614)
@adrienjoly adrienjoly changed the title repair soundcloud integration ? repair soundcloud integration Sep 9, 2023
@adrienjoly
Copy link
Member Author

Situation:

  • list of soundcloud tracks posted recently on openwhyd.org:
> db.post.find({eId:/^\/sc\//}).sort({_id:-1}).projection({eId:1})

{ "_id" : ObjectId("64f6fceceb5a936558ee1854"), "eId" : "/sc/metroverlaine/manchester#https://api.soundcloud.com/tracks/219691983/stream" }
{ "_id" : ObjectId("64eea712ba6d8bf8a2471b8b"), "eId" : "/sc/noraenpure/rufus-you-were-right-nora-en-pure-remix-1#https://api.soundcloud.com/tracks/220726941/stream" }
{ "_id" : ObjectId("648d30757f358373aecb33d2"), "eId" : "/sc/undefined" }
{ "_id" : ObjectId("648d30647f358373aecb33d1"), "eId" : "/sc/undefined" }
{ "_id" : ObjectId("648d30517f358373aecb33d0"), "eId" : "/sc/undefined" }
{ "_id" : ObjectId("648d303f7f358373aecb33cf"), "eId" : "/sc/undefined" }
{ "_id" : ObjectId("648d30277f358373aecb33ce"), "eId" : "/sc/undefined" }
{ "_id" : ObjectId("648d30167f358373aecb33cd"), "eId" : "/sc/undefined" }
{ "_id" : ObjectId("648d30077f358373aecb33cc"), "eId" : "/sc/undefined" }
{ "_id" : ObjectId("648d2ff77f358373aecb33cb"), "eId" : "/sc/undefined" }
{ "_id" : ObjectId("648d2fe17f358373aecb33ca"), "eId" : "/sc/undefined" }
{ "_id" : ObjectId("6452e03ac1668f2ef7a6d024"), "eId" : "/sc/kygo/ed-sheeran-passenger-no#http://api.soundcloud.com/tracks/106185859" }
{ "_id" : ObjectId("645117a40767b76a40dbbd39"), "eId" : "/sc/nuclearblastrecords/epica-resign-to-surrender#https://api.soundcloud.com/tracks/5169867" }
{ "_id" : ObjectId("644479d7a3679c486da8766d"), "eId" : "/sc/undefined" }
{ "_id" : ObjectId("63fd8eb4f5702509ff421422"), "eId" : "/sc/behappy-13/cece-winans-i-promise-wedding-song#https://api.soundcloud.com/tracks/208557646" }
{ "_id" : ObjectId("63e9a9b5ff1f90134bda6530"), "eId" : "/sc/filabrazilliaofficial/july-23#https://api.soundcloud.com/tracks/301836164/stream" }
{ "_id" : ObjectId("63d550d8c8596e1b8fe3debb"), "eId" : "/sc/yunizon-records/neptune-safari-morning-sun-2#https://api.soundcloud.com/tracks/141357506" }
{ "_id" : ObjectId("63a346f57764811eed14e188"), "eId" : "/sc/nuderecordlabel/all-the-birds-no-bird-fx-masteredwav#https://api.soundcloud.com/tracks/258637034/stream" }
{ "_id" : ObjectId("639352d8c21d6309da72dce0"), "eId" : "/sc/malrow/michael-jackson-scream-malrow-remix#https://api.soundcloud.com/tracks/147048504" }
{ "_id" : ObjectId("6388f71dc21d6309da72dacf"), "eId" : "/sc/undefined" }
image

@adrienjoly
Copy link
Member Author

adrienjoly commented Sep 9, 2023

Possible root causes for some of these issues: #433, #465.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant