Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hot-tracks): don't include invalid SoundCloud eId #719

Merged

Conversation

adrienjoly
Copy link
Member

@adrienjoly adrienjoly commented Sep 7, 2023

Contributes to #718 and #614.

What does this PR do / solve?

The top track listed on the hot tracks page has an invalid SoundCloud eId, causing its score to artificially accumulate the stats of all posts with that same invalid eId: "/sc/undefined".

    {
      "_id": "53f5d7af7b4e770b172679bc",
      "uId": "52e2620f7e91c862b2b3f66a",
      "uNm": "Rien",
      "text": "",
      "pl": { "name": "Balkan Beat Gypsy #03", "id": 144 },
      "name": "Haris Pilton - Gypsy Partizans (2013)",
      "eId": "/sc/undefined",
      "img": "https://i1.sndcdn.com/artworks-000047093292-y6wbnv-large.jpg?e76cf77",
      "nbP": 958,
      "lov": [
        "53da584ce04b7b4fca7cf528",
        "518b5a447e91c862b2adea1a",
        "6485e598d1b1033fa650d66b"
      ],
      "nbR": 213,
      "score": 900,
      "nbL": 19,
      "prev": 900,
      "trackId": "54bf88e3e04b7b4fca82c18f",
      "rankIncr": 0,
      "trackUrl": "//soundcloud.com/undefined",
      "isLoved": false
    }

Overview of changes

Until we fix the root cause (see #614), skip tracks with invalid soundcloud eId.

@adrienjoly adrienjoly marked this pull request as ready for review September 7, 2023 15:57
@adrienjoly adrienjoly self-assigned this Sep 7, 2023
@adrienjoly adrienjoly added the bug label Sep 7, 2023
@adrienjoly adrienjoly merged commit 9b25e3d into main Sep 7, 2023
16 of 19 checks passed
@adrienjoly adrienjoly deleted the fix/hot-tracks-dont-include-invalid-soundcloud-eid branch September 7, 2023 16:01
@codacy-production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for fe21d191
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (fe21d19) Report Missing Report Missing Report Missing
Head commit (0796f6c) 5155 3270 63.43%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#719) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

adrienjoly pushed a commit that referenced this pull request Sep 7, 2023
## [1.55.65](v1.55.64...v1.55.65) (2023-09-07)

### Bug Fixes

* **hot-tracks:** don't include invalid SoundCloud `eId` ([#719](#719)) ([9b25e3d](9b25e3d)), closes [#718](#718) [#614](#614) [#3](#3) [#614](#614)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant