fix(tests): Try to reduce Cypress flakiness by tracing JSON parsing errors #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
This was referenced Dec 21, 2021
adrienjoly
added a commit
that referenced
this pull request
Dec 26, 2021
) ## Problem Despite several attempts to improve the situation (see PRs #501, #504, #505, #507, #508, #510, #513, #520, #521, #522), Cypress tests are still flaky: they timeout for random reasons. ## Hypothesis This timeout could be caused by the fact that: - some XHR requests (e.g. to `/api/notif` to fetch notifications, and Deezer) may never respond => `onLoad` is never triggered - when a new test starts, we call `/testing/reset` to refresh the DB, which can cause pending DB queries from never resolving See #520 (comment). ## Proposed solution - wait for Openwhyd server to be up and reset before running tests - intercept and mock flaky XHR requests - fail faster when test steps are hanging for too long - reduce the amount of resources to load: fonts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf https://github.com/openwhyd/openwhyd/runs/4486269717?check_suite_focus=true#step:8:743