Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Disable Cypress retries until it's fixed #513

Merged
merged 1 commit into from
Dec 18, 2021
Merged

ci: Disable Cypress retries until it's fixed #513

merged 1 commit into from
Dec 18, 2021

Conversation

adrienjoly
Copy link
Member

@adrienjoly adrienjoly commented Dec 18, 2021 •
edited

@adrienjoly adrienjoly self-assigned this Dec 18, 2021
@adrienjoly adrienjoly added the bug label Dec 18, 2021
@sonarcloud
Copy link

sonarcloud bot commented Dec 18, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@adrienjoly adrienjoly merged commit 5a57df3 into master Dec 18, 2021
@adrienjoly adrienjoly deleted the ci/disable-cypress-retries-for-now branch December 18, 2021 16:24
This was referenced Dec 21, 2021
Merged
Merged
adrienjoly added a commit that referenced this pull request Dec 26, 2021
@adrienjoly
fix(tests): Fix cypress flakiness on CI by slowing down test setup (#523
b9c8707 
)

## Problem

Despite several attempts to improve the situation (see PRs #501, #504, #505, #507, #508, #510, #513, #520, #521, #522), Cypress tests are still flaky: they timeout for random reasons.

## Hypothesis

This timeout could be caused by the fact that:
- some XHR requests (e.g. to `/api/notif` to fetch notifications, and Deezer) may never respond => `onLoad` is never triggered
- when a new test starts, we call `/testing/reset` to refresh the DB, which can cause pending DB queries from never resolving

See #520 (comment).

## Proposed solution

- wait for Openwhyd server to be up and reset before running tests
- intercept and mock flaky XHR requests
- fail faster when test steps are hanging for too long
- reduce the amount of resources to load: fonts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@adrienjoly adrienjoly

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@adrienjoly