Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: reduce docker image size #607

Merged
merged 1 commit into from
May 7, 2023
Merged

ci: reduce docker image size #607

merged 1 commit into from
May 7, 2023

Conversation

adrienjoly
Copy link
Member

@adrienjoly adrienjoly commented May 7, 2023 •
edited

cf https://github.com/tj/node-prune#installation

See https://hub.docker.com/r/openwhyd/openwhyd/tags for impact on size:

image

(screenshot is before this PR is merged)

@adrienjoly adrienjoly self-assigned this May 7, 2023
@adrienjoly adrienjoly marked this pull request as ready for review May 7, 2023 15:17
@adrienjoly adrienjoly merged commit 1d147b3 into main May 7, 2023
13 of 14 checks passed
@adrienjoly adrienjoly deleted the ci/reduce-docker-image-size branch May 7, 2023 15:17
@adrienjoly
Copy link
Member Author

impact is not noticable:

image

@adrienjoly
Copy link
Member Author

Note: we saved ~10 MB by pruning old/unused dependencies (see PR #610)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@adrienjoly adrienjoly

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@adrienjoly