Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove old deps (found by knip) #610

Merged
merged 1 commit into from
May 19, 2023
Merged

Conversation

adrienjoly
Copy link
Member

No description provided.

@adrienjoly adrienjoly self-assigned this May 19, 2023
@adrienjoly adrienjoly added the dependencies Pull requests that update a dependency file label May 19, 2023
@adrienjoly
Copy link
Member Author

adrienjoly commented May 19, 2023

For reference, here's the output from knip:

$ nvm use 18
Now using node v18.15.0 (npm v9.5.0)

$ npx knip  
Unused files (173)
app/controllers/LibAll.js
app/controllers/LibFriends.js
app/controllers/LibUser.js
app/controllers/LibUserPlaylist.js
app/controllers/LibUserProfile.js
app/controllers/admin/FileController.js
app/controllers/admin/analytics.js
app/controllers/admin/config.js
app/controllers/admin/db.js
app/controllers/admin/index.js
app/controllers/admin/invites.js
app/controllers/admin/notif.js
app/controllers/admin/stats.js
app/controllers/admin/test.js
app/controllers/admin/testEmail.js
app/controllers/admin/testMainTemplate.js
app/controllers/admin/testNotifs.js
app/controllers/admin/testTemplates.js
app/controllers/admin/testUpload.js
app/controllers/admin/tests/follow.js
app/controllers/admin/tests/playlist.js
app/controllers/admin/tests/stream.js
app/controllers/admin/users.js
app/controllers/api/facebookLogin.js
app/controllers/api/fbfriends.js
app/controllers/api/follow.js
app/controllers/api/lastFm.js
app/controllers/api/login.js
app/controllers/api/notif.js
app/controllers/api/playlist.js
app/controllers/api/post.js
app/controllers/api/postEdit.js
app/controllers/api/searchHypeMachine.js
app/controllers/api/unsubscribe.js
app/controllers/api/user.js
app/controllers/consent.js
app/controllers/hotTracks.js
app/controllers/iframe.js
app/controllers/invite.js
app/controllers/now.js
app/controllers/onboarding.js
app/controllers/pgApp.js
app/controllers/postViewer.js
app/controllers/private/config.js
app/controllers/private/contentType.js
app/controllers/private/fbCanvas.js
app/controllers/private/getResourceMetadata.js
app/controllers/private/password.js
app/controllers/private/playlistOrder.js
app/controllers/private/register.js
app/controllers/private/search.js
app/controllers/private/upload.js
app/controllers/private/visit.js
app/controllers/private/wsYoutube.js
app/controllers/recentActivity.js
app/controllers/redir.js
app/controllers/settings.js
app/controllers/static.js
app/controllers/subdir.js
app/controllers/testing/refresh.js
app/controllers/testing/reset.js
app/controllers/uploadedFile.js
app/controllers/userLibrary.js
app/lib/hypem/index.js
app/models/analytics.js
app/models/comment.js
app/models/emailAdminsOnly.js
app/models/emailFake.js
app/models/emailSendgrid.js
app/models/facebook.js
app/models/htmlDom.js
app/models/searchAlgolia.js
app/models/searchElastic.js
app/models/searchMongo.js
app/models/solrIndex.js
app/models/version.js
app/templates/adminLists.js
app/templates/feed.js
app/templates/inviteForm.js
app/templates/invitePage.js
app/templates/postViewer.js
app/templates/posts.js
app/templates/search.js
app/templates/uiSnippets.js
app/workers/fbGroupImport.js
applitools.config.js
config/initdb.js
config/initdb_testing.js
cypress/e2e/visual-snapshots.ts
cypress/fixtures/users.js
cypress/support/eyes-index.d.ts
misc/BrowserExt/Chrome/bookmarklet.js
misc/BrowserExt/Chrome/chrome.js
public/investors/init.js
public/js/TrackFinder.js
public/js/WhydImgUpload.js
public/js/ajaxUpload.js
public/js/autoresize.jquery.min.js
public/js/bookmarkletLogic.ts
public/js/bookmarkletPageDetectors.ts
public/js/bookmarkletUI.ts
public/js/bookmarkletUrlDetectors.ts
public/js/bookmarkletYouTube.ts
public/js/cookieconsent2-3.0.3.min.js
public/js/dndUpload.js
public/js/dropzone.js
public/js/facebook.js
public/js/feed-edit.js
public/js/feed-filter.js
public/js/feed-trackorder.js
public/js/hotTracks.js
public/js/jquery-1.10.2.min.js
public/js/jquery-1.8.2.js
public/js/jquery-1.8.2.min.js
public/js/jquery-migrate-1.2.1.js
public/js/jquery-ui-1.9.0.sortable.min.js
public/js/jquery.avgrund.js
public/js/jquery.elastic.js
public/js/jquery.history.js
public/js/jquery.iframe-post-form.min.js
public/js/jquery.mentionsInput.js
public/js/jquery.placeholder.min.js
public/js/jquery.tinyscrollbar.min.js
public/js/jquery.tipsy.js
public/js/md5.js
public/js/mustache.js
public/js/onboarding.js
public/js/playem-all.js
public/js/playem-min.js
public/js/playem-youtube-iframe-patch.js
public/js/playem-youtube-iframe.js
public/js/postBox.js
public/js/postBoxV2.js
public/js/postPage.js
public/js/quickSearch.js
public/js/searchPage.js
public/js/settings.js
public/js/soundmanager2-nodebug-jsmin.js
public/js/soundmanager2.js
public/js/ui.js
public/js/underscore-min.js
public/js/whyd.js
public/js/whydEmbed.js
public/js/whydPlayer.js
public/js/whydRemotePlayer.js
public/js/whydtr.js
public/press/js/jquery-1.10.2.min.js
public/press/js/sliderz.v1.js
public/tests/TestRunner.js
public/tests/loggedin.js
public/tests/testNotifs.js
scripts/algolia-search-index/Progress.js
scripts/algolia-search-index/algolia-utils.js
scripts/algolia-search-index/mongodb-wrapper.js
scripts/algolia-search-index/run-diff-reindex.js
scripts/algolia-search-index/wip.js
scripts/data-analysis-scripts/src/convert-json-to-csv.js
scripts/data-analysis-scripts/src/json-helpers/map-reduce-over-json-lines.js
scripts/data-analysis-scripts/src/json-helpers/run-mongo-script-from-json-dump.js
scripts/data-analysis-scripts/src/list-error-codes-per-period.js
scripts/data-analysis-scripts/src/list-error-types-per-player.js
scripts/data-analysis-scripts/src/mongo-helpers/date-range.mongo.js
scripts/data-analysis-scripts/src/mongo-helpers/list-error-codes-per-period.mongo.js
scripts/data-analysis-scripts/src/mongo-helpers/list-error-types-per-player.mongo.js
scripts/data-analysis-scripts/src/mongo-helpers/period-aggregator.mongo.js
scripts/data-analysis-scripts/src/plot-nb-play-errors-per-day.mongo.js
scripts/data-analysis-scripts/src/plot-nb-plays-per-day.mongo.js
scripts/data-analysis-scripts/src/plot-nb-posts-per-day.mongo.js
scripts/data-analysis-scripts/src/plot-nb-users-listening-per-day.mongo.js
scripts/data-analysis-scripts/src/plot-nb-users-posting-per-day.mongo.js
scripts/data-analysis-scripts/src/plot-user-growth.mongo.js
scripts/import-from-prod.js
wallaby.conf.js
Unused dependencies (5)
algoliasearch  package.json
emailjs        package.json
ent            package.json
htmlparser     package.json
playemjs       package.json
Unused devDependencies (2)
chai          package.json
chai-exclude  package.json
Unlisted dependencies (5)
jest       .github/workflows/ci.yml
tsc        .github/workflows/ci.yml
jest       package.json            
kill-port  package.json            
tsc        package.json
Unlisted binaries (3)
docker-compose                    package.json
scripts/transpile-bookmarklet.sh  package.json
semantic-release                  package.json

Note: there are many false positives.

@cypress
Copy link

cypress bot commented May 19, 2023

Passing run #897 ↗︎

0 26 1 0 Flakiness 0

Details:

Merge 53331a6 into 1d147b3...
Project: Openwhyd Commit: b6603e1e5a ℹ️
Status: Passed Duration: 02:43 💡
Started: May 19, 2023 12:25 PM Ended: May 19, 2023 12:28 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@adrienjoly adrienjoly marked this pull request as ready for review May 19, 2023 12:34
@adrienjoly adrienjoly merged commit 7f79ef1 into main May 19, 2023
17 checks passed
@adrienjoly adrienjoly deleted the fix/remove-old-deps branch May 19, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant