fix: deprecated callbacks passed to mongodb, in `post` model #680

adrienjoly · 2023-08-24T09:10:32Z

Contributes to #634.

cause: some refs were probably not detected earlier, because of complicated callback logic contributes to #580.

codacy-production · 2023-08-24T09:15:19Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
+1.95%	58.11%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`26cfb9f`)	5131	3035	59.15%
Head commit (`a720c47`)	5128 (-3)	3133 (+98)	61.10% (+1.95%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#680)	74	43	58.11%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

… import("/Users/adrienjoly/Code/openwhyd/app/models/config")'`

…Page')` cf https://github.com/openwhyd/openwhyd/actions/runs/5983938243/job/16234633467?pr=680#step:7:22

…s of the track

!BREAKING

…track` => make sure that db is cleared between each test

…isolated/independant from other tests of the suite

…as `track` documents are created lazily

… defined

…in db

adrienjoly · 2023-08-28T10:00:01Z

Note about the following FIXME comment:

FIXME: We are forced to use the ADMIN_USER, since DUMMY_USER is mutated by user.api.tests.js and the db cleanup seems to not work for the users collection.
May be initdb_testing.js is not up to date with the current schema?

I believe that I have reproduced that issue in fix test, to match with schema of posts, as seen in failing post API tests, only after they are run after playlist API tests (which mutate DUMMY_USER in the db). See logs: https://github.com/openwhyd/openwhyd/actions/runs/5998120167/job/16265796818?pr=680#step:6:172

After investigating locally:

posts test pass when they are run alone
when they are run after playlist tests, requests are rejected with 400 (badRequest) by handleRequest because user is an empty object. Hence the hypothesis of the test users not being properly reset between test suites.

EDIT: Indeed, tests work as expected when skipping the rename action nested test suite from test/api/playlist.api.tests.js (which call insertTestData in the user collection, with an altered version of DUMMY_USER).

Hypothesis: bad state reset could be caused by failed to kill by pid: kill ESRCH error after running each test of npm run test:api

example for #684.

…n was expected.`

…685) Contributes to #684. * fix test helpers based on trouble while working on PR #680 * fix: check that we're on test database before refreshing db caches * report cleanup errors if any * fixtures: make test users immutable * 🧹 `failed to kill by pid: kill ESRCH` errors when running integration/api tests * skip flaky unit test * migrate playlist API tests to `OpenwhydTestEnv` * fix `listen EADDRINUSE: address already in use :::8080` when api tests are running on CI, with coverage cf https://github.com/openwhyd/openwhyd/actions/runs/6000177975/job/16271736742#step:6:266 * refactor(fixtures): extract resetTestDb() from cleanup() * ✨ use OpenwhydTestEnv.reset() instead of fixtures.cleanup(), in playlist API tests * extract and increase timeout/tolerance for algolia (3rd-party) tests cf `Exceeded timeout of 20000 ms for a hook` at https://github.com/openwhyd/openwhyd/actions/runs/6000432446/job/16272475960#step:5:81

fix callbacks passed to mongodb, in post model

67889a1

adrienjoly changed the title ~~fix callbacks passed to mongodb, in post model~~ fix: callbacks passed to mongodb, in post model Aug 24, 2023

adrienjoly self-assigned this Aug 24, 2023

adrienjoly changed the title ~~fix: callbacks passed to mongodb, in post model~~ fix: deprecated callbacks passed to mongodb, in post model Aug 24, 2023

adrienjoly added the enhancement label Aug 24, 2023

adrienjoly added 2 commits August 24, 2023 11:14

fix counter of refs to deprecated usernames cache

653b676

cause: some refs were probably not detected earlier, because of complicated callback logic contributes to #580.

fix(codacy): Always provide a base when using parseInt() functions

20e4460

adrienjoly added 22 commits August 24, 2023 11:15

check for TypeScript errors in post.js

9cfa1d9

fix `Property 'nbPostsPerNewsfeedPage' does not exist on type 'typeof…

10fbcd5

… import("/Users/adrienjoly/Code/openwhyd/app/models/config")'`

fix deprecated mongodb options

efcc985

Merge branch 'main' into fix/deprecated-mongodb-calls-in-post-model

74c5b8c

Merge branch 'main' into fix/deprecated-mongodb-calls-in-post-model

fc046cf

fix `Cannot read properties of undefined (reading 'nbPostsPerNewsfeed…

9fd381a

…Page')` cf https://github.com/openwhyd/openwhyd/actions/runs/5983938243/job/16234633467?pr=680#step:7:22

add test: incrPlayCounter action should increase the number of play…

77edf14

…s of the track

add failing test: incrPlayCounter action should return the post _id

ffb873d

fix(api): incrPlayCounter action to not return the post object anymore

a4eb5e5

!BREAKING

add failing test: `should increase the total number of plays of that …

a8e3e9a

…track` => make sure that db is cleared between each test

fix test post api should add a track to a new playlist, to make it …

69aaf04

…isolated/independant from other tests of the suite

fix test: should increase the total number of plays of that track, …

016a2be

…as `track` documents are created lazily

test should not pass => make updateByEid assert that eId param is…

7c80f71

… defined

fix test by setting a eId

3699eee

fix incrPlayCounter impl. by fetching the post's eId

eb70134

playlist tests: prevent side effects between tests

b905a99

refactor: extract callPlaylistApi

a457874

playlist tests: use DUMMY_USER instead of ADMIN_USER

58334a4

playlist tests: make sure that freshly created playlist is persisted …

1309274

…in db

add test: should rename a playlist

fa5a7d3

add failing test: should update the playlist's name in associated posts

391e10a

fix: userModel.setPlaylist to await the update of posts

9fa8e9b

fix test, to match with schema of posts

08c3b1d

adrienjoly mentioned this pull request Aug 28, 2023

Make sure that DB state is properly reset between execution of each API test suite #684

Closed

adrienjoly added 3 commits August 28, 2023 13:00

be more decisive on when to cleanup, in post.api.tests.js

7c1ed4d

skip tests that cause side effects on other tests

0dc45c0

example for #684.

fix(sonar): `Promise returned in function argument where a void retur…

f10f9ee

…n was expected.`

adrienjoly force-pushed the fix/deprecated-mongodb-calls-in-post-model branch from 07ca189 to f10f9ee Compare August 28, 2023 12:33

adrienjoly added a commit that referenced this pull request Aug 28, 2023

fix test helpers based on trouble while working on PR #680

038cba7

adrienjoly added 5 commits August 29, 2023 17:12

Merge branch 'main' into fix/deprecated-mongodb-calls-in-post-model

a9ea2e9

🙌 re-enable all playlist api tests

2bc83fa

remove callback from setPlaylist()

f9e46cb

add tests for playlist removal and its impact on associated posts

36de9a6

remove callback from unsetPlaylist()

27fa84d

adrienjoly marked this pull request as ready for review August 29, 2023 15:32

adrienjoly added 6 commits August 29, 2023 17:38

fix some error cases, based on code review

a720c47

simplify call expression

2d15e8c

refactor: move up insertPost() and callPostApi() helpers

ac0bef8

add tests for toggleLovePost

dedac32

reveal missing callbacks in setPostLove

76c3f66

remove callback from setPostLove()

de25802

adrienjoly merged commit 8abd8d8 into main Aug 29, 2023
18 checks passed

adrienjoly deleted the fix/deprecated-mongodb-calls-in-post-model branch August 29, 2023 16:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: deprecated callbacks passed to mongodb, in `post` model #680

fix: deprecated callbacks passed to mongodb, in `post` model #680

adrienjoly commented Aug 24, 2023 •

edited

Loading

codacy-production bot commented Aug 24, 2023 •

edited

Loading

adrienjoly commented Aug 28, 2023 •

edited

Loading

fix: deprecated callbacks passed to mongodb, in post model #680

fix: deprecated callbacks passed to mongodb, in post model #680

Conversation

adrienjoly commented Aug 24, 2023 • edited Loading

codacy-production bot commented Aug 24, 2023 • edited Loading

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

adrienjoly commented Aug 28, 2023 • edited Loading

fix: deprecated callbacks passed to mongodb, in `post` model #680

fix: deprecated callbacks passed to mongodb, in `post` model #680

adrienjoly commented Aug 24, 2023 •

edited

Loading

codacy-production bot commented Aug 24, 2023 •

edited

Loading

adrienjoly commented Aug 28, 2023 •

edited

Loading